From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15902 invoked by alias); 12 Sep 2004 16:33:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15891 invoked from network); 12 Sep 2004 16:33:41 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 12 Sep 2004 16:33:41 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8CGXZur013876 for ; Sun, 12 Sep 2004 12:33:35 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8CGXYr20060; Sun, 12 Sep 2004 12:33:34 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E900E28D2; Sun, 12 Sep 2004 12:31:23 -0400 (EDT) Message-ID: <414479DB.4090207@gnu.org> Date: Sun, 12 Sep 2004 16:33:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Eli Zaretskii Cc: Daniel Jacobowitz , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Eliminate TARGET_HAS_HARDWARE_WATCHPOINTS References: <413C6E8E.6030607@gnu.org> <01c49441$Blat.v2.2.2$ead61420@zahav.net.il> <413E25F6.7020908@gnu.org> <01c49557$Blat.v2.2.2$23f700a0@zahav.net.il> <413F170A.2070005@gnu.org> <01c495b7$Blat.v2.2.2$1f83c660@zahav.net.il> <20040908152315.GA28927@nevyn.them.org> <01c4961e$Blat.v2.2.2$d00fd3e0@zahav.net.il> <20040909035336.GA30215@nevyn.them.org> <01c49621$Blat.v2.2.2$eb2d05a0@zahav.net.il> <20040909124755.GA8559@nevyn.them.org> <01c4969e$Blat.v2.2.2$0e5a13c0@zahav.net.il> In-Reply-To: <01c4969e$Blat.v2.2.2$0e5a13c0@zahav.net.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00197.txt.bz2 >>Date: Thu, 9 Sep 2004 08:47:56 -0400 >>> From: Daniel Jacobowitz >>> Cc: cagney@gnu.org, gdb-patches@sources.redhat.com >>> >> >>>> > I understand the theory, I just don't know how to test for watchpoint >>>> > support in a program by just compiling it. If you can suggest a >>>> > program whose compilation will reveal that, please do. >> >>> >>> There's nothing generic controlled by TARGET_HAS_HARDWARE_WATCHPOINTS. >>> It controls an include of in i386v-nat.c - that can be >>> autoconf'd, and then checked for the appropriate DR_* constants if >>> that's necessary. It controls the use of prwatch_t in procfs.c, >>> likewise. > > > I'm not sure the mere presence of DR_* automatically means that > hardware watchpoints are supported at run time. I'd prefer to hear > that from Mark or someone else who could tell for sure. > > In any case, if the above is true, then there should be no problem to > write an Autoconf test that would replace > TARGET_HAS_HARDWARE_WATCHPOINTS. As soon as that is posted here, I > will withdraw all my objections to removing the old macro in favor of > the new mechanism. This assumes that we've access to machines to test it on, and the code being modified is even being used / worth retaining. Resolving both of those takes this from a no-problem task to something best handled separatly, and something that should not block this current patch. Andrew