From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16703 invoked by alias); 12 Sep 2004 15:45:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16693 invoked from network); 12 Sep 2004 15:45:48 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 12 Sep 2004 15:45:48 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8CFjlqT003992 for ; Sun, 12 Sep 2004 11:45:48 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8CFjlr07237; Sun, 12 Sep 2004 11:45:47 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id C525728D2; Sun, 12 Sep 2004 11:43:35 -0400 (EDT) Message-ID: <41446EA7.8070603@gnu.org> Date: Sun, 12 Sep 2004 15:45:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Paul Hilfinger Cc: gdb-patches@sources.redhat.com Subject: Re: [commit] Move hex_string et.al. to defs.h / utils.c References: <20040911194329.1B29DF2E3A@nile.gnat.com> In-Reply-To: <20040911194329.1B29DF2E3A@nile.gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00194.txt.bz2 >>> Somehow some some #include "language.h" were lost with PaulH's recent >>> *_string_custom cleanup. > > >>> Rather than add lots of those includes, I moved the hex_string and >>> hex_string_custom functions to utils.c, and the corresponding >>> declaration to defs.h. I also took the oportunity to improve the code a >>> little switching it to get_cell(). > > > Andrew, > > Actually, the #includes were dropped deliberately, and you've done the piece > what was SUPPOSED to happen and somehow got dropped: moving the decls to > defs.h and defns to utils.c. Thanks. "oops" :-) > I must be careful not to overlook > mere warnings (speaking of which, it would be a nice goal to remove all > warnings from GDB compilations, lest they distract). You should always configure with --enable-gdb-warnings=,-Werror (perhaphs GDB should automatically configure in -Werror when there's a CVS repository say). See: http://sources.redhat.com/gdb/current/onlinedocs/gdbint_13.html#SEC119 You'll also want to check out gdb_mbuild.sh. >>> To answer your question about my thoughts on get_cell - I think it sux >>> less than the old code's local static buffer :-) > > > It does make one long for fast GC, does it not? Or perhaps something > region-based, where the region gets deallocated at, say, a point in the > top-level command loop. Garbage collection, yes. Andrew