From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12180 invoked by alias); 5 Sep 2007 00:10:50 -0000 Received: (qmail 12168 invoked by uid 22791); 5 Sep 2007 00:10:49 -0000 X-Spam-Check-By: sourceware.org Received: from a.mail.sonic.net (HELO a.mail.sonic.net) (64.142.16.245) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Sep 2007 00:10:44 +0000 Received: from webmail.sonic.net (b.webmail.sonic.net [64.142.100.148]) by a.mail.sonic.net (8.13.8.Beta0-Sonic/8.13.7) with ESMTP id l850Aaet000946; Tue, 4 Sep 2007 17:10:36 -0700 Received: from 12.7.175.2 (SquirrelMail authenticated user msnyder) by webmail.sonic.net with HTTP; Tue, 4 Sep 2007 17:10:36 -0700 (PDT) Message-ID: <4144.12.7.175.2.1188951036.squirrel@webmail.sonic.net> In-Reply-To: <20070904142440.GD3579@adacore.com> References: <15003.12.7.175.2.1188424188.squirrel@webmail.sonic.net> <20070904142440.GD3579@adacore.com> Date: Wed, 05 Sep 2007 00:10:00 -0000 Subject: Re: [patch] strlen(null) in dwarf2read From: msnyder@sonic.net To: "Joel Brobecker" Cc: msnyder@sonic.net, gdb-patches@sourceware.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00062.txt.bz2 >> 2007-08-29 Michael Snyder >> >> * dwarf2read.c (determine_prefix): Do not send NULL to strlen. > > Proofread, and no comment :) > > (actually, yes: I'm much better at reading unified diff, not sure > about others - I ended up applying your patch locally and regenerating > the diff) All right. The reason I like -p is because it gives me the function name for context. I can see that -u is more concise. Wonder if there is a way to get the best of both?