From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24036 invoked by alias); 11 Sep 2004 02:03:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22911 invoked from network); 11 Sep 2004 02:03:26 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 11 Sep 2004 02:03:26 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.10) with ESMTP id i8B23K0v027304 for ; Fri, 10 Sep 2004 22:03:20 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i8B23Kr07740; Fri, 10 Sep 2004 22:03:20 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5B73F28D2; Fri, 10 Sep 2004 22:09:51 -0400 (EDT) Message-ID: <41425E6F.4050607@gnu.org> Date: Sat, 11 Sep 2004 02:03:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Paul Hilfinger Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] patch to remove language-dependent numeric output support References: <20040911003752.B1A86F2D86@nile.gnat.com> In-Reply-To: <20040911003752.B1A86F2D86@nile.gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00177.txt.bz2 > [Ooops. I see my previous Subject line was a bit mangled. So here is > the same patch with a more meaningful subject.] Think your self lucky - my disk failed and ate it :-) > At Andrew's request, I've prepared a patch that removes the > (essentially unused) features in the language vector and elsewhere > that provide for language-dependent integral output formats. The > patch below causes GDB to use C-format throughout instead. This change > does indeed allow for a bit of brush removal. > > The idea is that if language-specific formatting were ever to be > re-introduced, it would be via a function in the language vector. (I'd > suggest that such a function take a raw string of digits and perhaps > their radix, and work from that. For C, it would stick 0x or 0 in > front, according to radix and value; for Ada, it would stick RADIX# in > front and # after for non-decimal radices). > > The patch would have been a lot shorter, but several name changes seemed > indicated. Comments solicited. the code changes are ok - the language specific changes being mindless follow suit (and I think I'll have a drink, thanks!). Just some notes though: > (local_decimal_format_custom): Remove. > > * utils.c: (int_string): New function. I suspect that the the blank lines aren't needed - blank lines separate commits rather than separate parts of the same commit - whichever. > functions. We have to split this up into separate print > - statements because local_hex_string returns a local static > + statements because hex_string returns a local static can you file a bug report - that pre-existing behavior is a recipe for desaster :-( Makefile.in will eventually need an update. If you want to do it there's a script (gdb_makefile.in) hanging off of the ari web page that you might find useful. Fixing the file is obvious. I suspect that the special Makefile rule for printcmd.o can be deleted - something for later. Ditto. Again, thanks. Now where were we with Ada. Andrew