Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Deprecate XM_FILE and TM_FILE
Date: Thu, 09 Sep 2004 16:05:00 -0000	[thread overview]
Message-ID: <41407F45.2090401@gnu.org> (raw)
In-Reply-To: <01c492ff$Blat.v2.2.2$4fec0480@zahav.net.il>

Earlier you wrote:

> What I would have expected is that if you make a change that has a
> potential to break some port, you at the same time commit a change
> that fixes the potential damage.

Just so that we're on the same page, my change has not been committed:
- per last flame war, deprecations are given a week
- I clearly stated ``I'll _look_ to commit this in a week,''
- a check of CVS shows no such commit
however:
- the subject line specified `PATCH'
While we've all come to learn that the word PATCH in the subject line 
conveys no meaning (committed? rfa? rfc? ...?), I should have remembered 
to avoid it - brain fart.

First, lets just clarify something>>> Date: Sat, 04 Sep 2004 16:37:18 -0400
>>> From: Andrew Cagney <cagney@gnu.org>
>>> Cc: gdb-patches@sources.redhat.com
>>> 
>>> Here, the xm-go32.h file will have been removed before the XM_FILE 
>>> mechanism goes away (if it hasn't we've both seriously fallen down on 
>>> the job :-) and therefore, DJGPP won't be broken.
> 
> 
> Who is going to replace xm-go32.h with something that will preserve
> the functionality?  And why isn't that something checked in before
> XM_FILE is deprecated?

We've the following mechanisms:

	*.mh:XM_FILE
	#define GDBINIT_FILENAME
	#define CRLF_SOURCE_FILES
	#define DIRNAME_SEPARATOR

Here I'm ``disapproving'' the mechanism XM_FILE and have said nothing of 
GDBINIT_FILENAME et.al.

Now if I were to try to either:

- deprecate or delete GDBINIT_FILENAME without a replacement
- delete XM_FILE without eliminating DJGPP's dependence

then you'd have strong grounds for complaint.  Fortunatly, I've been 
very careful to not do this.

So to back you your original question.  I think you're asking who will 
cut the code necessary to acheive each of:

- eliminate/replace GDBINIT_FILENAME from xm-*.h
- eliminate/replace CRLF_SOURCE_FILES from xm-*.h
- eliminate/replace DIRNAME_SEPARATOR from xm-*.h

as they block the elimination (not deprecation) of XM_FILE.

short answer: I don't know.

long answer: It doesn't matter.
What matters is that it gets done.  To that end we're both ultimatly 
responsble for ensuring that it does.

Having said that, I think we can assume that it will end up being me 
that does the dirty work.

Andrew




  reply	other threads:[~2004-09-09 16:05 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-02 18:30 Andrew Cagney
2004-09-02 20:26 ` Eli Zaretskii
2004-09-03 16:18   ` Andrew Cagney
2004-09-04 12:00     ` Eli Zaretskii
2004-09-04 14:27       ` Andrew Cagney
2004-09-04 16:28         ` Eli Zaretskii
2004-09-04 23:20           ` Andrew Cagney
2004-09-05  4:17             ` Eli Zaretskii
2004-09-09 16:05               ` Andrew Cagney [this message]
2004-09-09 19:31                 ` Eli Zaretskii
2004-09-09 20:26                   ` Andrew Cagney
2004-09-09 21:15                     ` Eli Zaretskii
2004-09-09 21:26                       ` Joel Brobecker
2004-09-10  9:35                         ` Eli Zaretskii
2004-09-10 12:41                           ` Mark Kettenis
2004-09-10 16:32                             ` Eli Zaretskii
2004-09-12 18:07                               ` Andrew Cagney
2004-09-12 18:36                                 ` Eli Zaretskii
2004-09-13 15:35                                   ` Andrew Cagney
2004-09-13 19:48                                     ` Eli Zaretskii
2004-09-13 21:07                                       ` Andrew Cagney
2004-09-13 21:30                                         ` Joel Brobecker
2004-09-24 22:06                                           ` Andrew Cagney
2004-09-15 12:15                                         ` Eli Zaretskii
2004-09-15 15:54                                           ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41407F45.2090401@gnu.org \
    --to=cagney@gnu.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox