From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VzPFFgDCAWb4vRUAWB0awg (envelope-from ) for ; Mon, 25 Mar 2024 14:27:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711391232; bh=j8qKF21PXRnwv0pPMlIeV3vx8IHWPrIUmPRSvCPb8pU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=r6a/jV7CL5M4ZSjliC4LBLUoEue0k2lSLJluOf0ATeA0TAHbxmaBlCMTDT99P9Nu/ CgXf+pyy+1oKHbU2zS7AXPNYSMo8P85YIw6eQlJYOHD0QPNnoJ5UnKngMQi8tU7iX2 3Nss3CNMpip7F+leo7Zfj7ltNRNjrOIJ+TK12TH8= Received: by simark.ca (Postfix, from userid 112) id 45D521E0C0; Mon, 25 Mar 2024 14:27:12 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=oal+HJHl; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2E1A31E0AC for ; Mon, 25 Mar 2024 14:27:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C6CAB3858404 for ; Mon, 25 Mar 2024 18:27:09 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 68BED3858D33 for ; Mon, 25 Mar 2024 18:26:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68BED3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68BED3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711391210; cv=none; b=e9KEBa0bb8L4iR2zG9eO5J4lf5Rfga1SR7QLdWrSRRF1+HiUyjdfrYENK6BYzhik+nEkNnHTuI9RNCj/H4+LfELE/SmuFeoKCG5WoFdLgvd6bSNhB3rmoa5dxIYMzsP+gXgReKwNsLCgvN5ByUky5ovDaVNZRDAqqE6/1YIM690= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711391210; c=relaxed/simple; bh=j8qKF21PXRnwv0pPMlIeV3vx8IHWPrIUmPRSvCPb8pU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=EXuybX/IGVCKyJOyT165I4i9eWQj5yWnj/PFMK+RBEalmVN4HhJeyRwADYLb6X47mz9woQFRS4++Rs7Fw45tPoZkfJzlKCG//8auXsb1kz5ZMFpXQ9OkjtZVkQrTwwUkkfe58LnYTq/a3zV+u2gFeHuEgaTjeyeU+ch1TL8GKhk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1711391208; bh=j8qKF21PXRnwv0pPMlIeV3vx8IHWPrIUmPRSvCPb8pU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oal+HJHlsHz2BGhnBN9JnIXhNgJz/QcjMxc39ft4YE/3rgR8exvn/RljZcBqZmOpQ Q8sDucmnEeFNTIo+Rg0ydVsCPLghYhenDr0rex4rzydj03c/XYUQ7J/yJeOFjWVOH2 5xbFcQuvul3Z96HRtGGwtTV/Cm+Om6JkYvTe6Rc8= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 60F461E0AC; Mon, 25 Mar 2024 14:26:48 -0400 (EDT) Message-ID: <413a66aa-e035-41cf-9af4-040685f89204@simark.ca> Date: Mon, 25 Mar 2024 14:26:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3 0/8] x86/Linux Target Description Changes To: Andrew Burgess , gdb-patches@sourceware.org Cc: hjl.tools@gmail.com References: <8734seteht.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <8734seteht.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/25/24 13:20, Andrew Burgess wrote: > Andrew Burgess writes: > >> In v3: >> >> - Rebased. Nasty merge conflict with 4bb20a6244b7091 which I think >> I've resolved, but am unable to test. Reposting so the author of >> that other commit can validate. >> >> - Initial testing looks good. Full tests are still running. > > Testing completed with no issues. H.J. Lu confirmed that this versions > didn't break the x32 behaviour. I've gone ahead and pushed these > patches. > > If anything crops up then do let me know. > > Thanks, > Andrew > Hi Andrew, I think your series introduces some build failures with Clang. One is easy, it's a missing `-x c++` in gdbserver/Makefile.in. The other is: CXX nat/x86-linux-tdesc-ipa.o /home/smarchi/src/binutils-gdb/gdbserver/../gdb/nat/x86-linux-tdesc.c:167:1: error: unused function 'x86_linux_i386_tdesc_feature_mask' [-Werror,-Wunused-function] 167 | x86_linux_i386_tdesc_feature_mask () | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ It's possible that this function just needs to be moved in the same "#ifdef" as where it's used, but since I didn't follow your work closely, I prefer to let you fix it, in case I'm missing something. Thanks, Simon