From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20261 invoked by alias); 7 Sep 2004 21:20:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20252 invoked from network); 7 Sep 2004 21:20:05 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Sep 2004 21:20:05 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i87LJxS2008027 for ; Tue, 7 Sep 2004 17:20:04 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i87LJs304803; Tue, 7 Sep 2004 17:19:54 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0C6CD28D2; Tue, 7 Sep 2004 17:19:51 -0400 (EDT) Message-ID: <413E25F6.7020908@gnu.org> Date: Tue, 07 Sep 2004 21:20:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Eliminate TARGET_HAS_HARDWARE_WATCHPOINTS References: <413B1435.3020102@gnu.org> <01c493ce$Blat.v2.2.2$e86fbec0@zahav.net.il> <413C6E8E.6030607@gnu.org> <01c49441$Blat.v2.2.2$ead61420@zahav.net.il> In-Reply-To: <01c49441$Blat.v2.2.2$ead61420@zahav.net.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00113.txt.bz2 >>>> > In any case, I'd like to see the suggested Autoconf replacement for >>>> > this before we deprecate the feature. >> >>> >>> This is neither deprecating a feature, nor deprecating a system. > > > ``The feature'' in question is TARGET_HAS_HARDWARE_WATCHPOINTS. It is > being deprecated/removed, isn't it? The macro TARGET_HAS_HARDWARE_WATCHPOINTS is just a mechanism that core GDB might use (it doesn't) when implementing a [user visible] feature such as ``hardware watchpoints''. I'm not ``expressing disapproval of or wishing against'' the feature ``hardware watchpoints'', nor am I ``expressing disapproval of or wishing against'' systems that provide the feature ``hardware watchpoints''. However, I am formalizing our disapproval of the macro TARGET_HAS_HARDWARE_WATCHPOINTS. To which I wrote: > Here there are several things to notice: > > - core GDB no longer refers to TARGET_HAS_HARDWARE_WATCHPOINTS > At one stage target.h had definitions dependant on this macro, but no more. This patch removes the no-longer-needed defintion from configurations, such as GNU/Linux. > > - procfs.c and i386v-nat.c do refer to TARGET_HAS_HARDWARE_WATCHPOINTS > These files should be replying on an autoconf test. This patch replaces those cases with DEPRECATED_{PROCFS,I386V}_USE_HARDWARE_WATCHPOINTS macros. > > That leaves no definition so this patch also removes the corresponding documentation. Regarding the second of those points, procfs.c and i386v-nat.c: >>> Date: Mon, 06 Sep 2004 10:05:02 -0400 >>> From: Andrew Cagney >>> Cc: gdb-patches@sources.redhat.com >>> >>> I'll clarify the comments so that it is clear that: >>> >>> - it is native only >>> >>> - in all likelyhood all applicable current systems support this >>> mechanism so no autoconf test is needed (someone needs to do a proper >>> analysis) >>> >>> - its a configuration change, possibly involving an autoconf test > > > Sorry, I'm confused: what will a non-native port do to support both > targets that have hardware watchpoints and those which do not? Or are > you saying that _all_ targets have hardware watchpoint support now > (which I think is not true)? (my comments were for the native case only). For the non-native case, as I initially indicated and as an examination of the code reveals, this macro is never used! Consequently I've in no way motified or altered GDB's ``hardware watchpoints'' feature on those targets. Andrew