From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6043 invoked by alias); 6 Sep 2004 13:51:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6027 invoked from network); 6 Sep 2004 13:51:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 6 Sep 2004 13:51:18 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i86DpES2012858 for ; Mon, 6 Sep 2004 09:51:15 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i86DpE324336; Mon, 6 Sep 2004 09:51:14 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2250828D2; Mon, 6 Sep 2004 09:51:11 -0400 (EDT) Message-ID: <413C6B4E.2070009@gnu.org> Date: Mon, 06 Sep 2004 13:51:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Implement ptrace target vector inheritance References: <413B1E60.9060506@gnu.org> <01c493ce$Blat.v2.2.2$4f8cf380@zahav.net.il> In-Reply-To: <01c493ce$Blat.v2.2.2$4f8cf380@zahav.net.il> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-09/txt/msg00102.txt.bz2 > My comments are: > > (1) Let's have this machinery documented in gdbint.texinfo. The target vector. Yes, things-to-do-today. > (2) The patch introduces a couple of user commands (like `udot') > that should be documented in gdb.texinfo. I'll delete the commands, they are not necessary. > (3) Several hunks in the patch do not belong to it: they are merely > whitespace adjustments. Oops. I did `./gdb_indent.sh inf-*.[hc]` and picked up a couple stray files, fixed. Andrew