From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27998 invoked by alias); 5 Sep 2004 16:05:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 27990 invoked from network); 5 Sep 2004 16:05:55 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 5 Sep 2004 16:05:55 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i85G5oS2032296 for ; Sun, 5 Sep 2004 12:05:55 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i85G5m316889; Sun, 5 Sep 2004 12:05:48 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DEF6328D2; Sun, 5 Sep 2004 12:05:44 -0400 (EDT) Message-ID: <413B3958.1060108@gnu.org> Date: Sun, 05 Sep 2004 16:05:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040831 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [rfa] Delete keep_thread_db Content-Type: multipart/mixed; boundary="------------010809080902010807080106" X-SW-Source: 2004-09/txt/msg00094.txt.bz2 This is a multi-part message in MIME format. --------------010809080902010807080106 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 226 It would appear that, at one stage, this variable had something to do with corefiles, static programs and threads. That's no longer the case so this deletes the stray global. Tested on FC3 with no regressions, Ok? Andrew --------------010809080902010807080106 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 2866 Index: ChangeLog 2004-09-05 Andrew Cagney * thread-db.c (keep_thread_db): Delete. (thread_db_new_objfile, thread_db_create_inferior) (thread_db_mourn_inferior): Simplify assuming !keep_thread_db. Index: thread-db.c =================================================================== RCS file: /cvs/src/src/gdb/thread-db.c,v retrieving revision 1.43 diff -p -u -r1.43 thread-db.c --- thread-db.c 22 Jul 2004 01:31:49 -0000 1.43 +++ thread-db.c 5 Sep 2004 15:57:45 -0000 @@ -63,10 +63,6 @@ static void (*target_new_objfile_chain) /* Non-zero if we're using this module's target vector. */ static int using_thread_db; -/* Non-zero if we have to keep this module's target vector active - across re-runs. */ -static int keep_thread_db; - /* Non-zero if we have determined the signals used by the threads library. */ static int thread_signals; @@ -673,8 +669,6 @@ thread_db_new_objfile (struct objfile *o using_thread_db = 0; } - keep_thread_db = 0; - goto quit; } @@ -703,18 +697,6 @@ thread_db_new_objfile (struct objfile *o push_target (&thread_db_ops); using_thread_db = 1; - /* If the thread library was detected in the main symbol file - itself, we assume that the program was statically linked - against the thread library and well have to keep this - module's target vector activated until forever... Well, at - least until all symbols have been discarded anyway (see - above). */ - if (objfile == symfile_objfile) - { - gdb_assert (proc_handle.pid == 0); - keep_thread_db = 1; - } - /* We can only poke around if there actually is a child process. If there is no child process alive, postpone the steps below until one has been created. */ @@ -1106,12 +1088,8 @@ static void thread_db_create_inferior (char *exec_file, char *allargs, char **env, int from_tty) { - if (!keep_thread_db) - { - unpush_target (&thread_db_ops); - using_thread_db = 0; - } - + unpush_target (&thread_db_ops); + using_thread_db = 0; target_beneath->to_create_inferior (exec_file, allargs, env, from_tty); } @@ -1141,17 +1119,9 @@ thread_db_mourn_inferior (void) target_beneath->to_mourn_inferior (); - /* Detach thread_db target ops if not dealing with a statically - linked threaded program. This allows a corefile to be debugged - after finishing debugging of a threaded program. At present, - debugging a statically-linked threaded program is broken, but - the check is added below in the event that it is fixed in the - future. */ - if (!keep_thread_db) - { - unpush_target (&thread_db_ops); - using_thread_db = 0; - } + /* Detach thread_db target ops. */ + unpush_target (&thread_db_ops); + using_thread_db = 0; } static int --------------010809080902010807080106--