From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15584 invoked by alias); 1 Sep 2004 20:44:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 15575 invoked from network); 1 Sep 2004 20:44:03 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 1 Sep 2004 20:44:03 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i81Ki3S0029658 for ; Wed, 1 Sep 2004 16:44:03 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i81Khu327919; Wed, 1 Sep 2004 16:43:57 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i81Khkse028124; Wed, 1 Sep 2004 16:43:55 -0400 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id A9AD28001FC; Wed, 1 Sep 2004 16:43:46 -0400 (EDT) Message-ID: <41363482.7030204@redhat.com> Date: Wed, 01 Sep 2004 20:44:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Michael Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: Fix for pending breakpoints in manually loaded/unloaded shlibs References: <41191D71.60204@redhat.com> <20040811171203.GA4152@nevyn.them.org> <411A7D97.50104@redhat.com> <20040818135621.GA26257@nevyn.them.org> <4123AC6E.8000300@redhat.com> <20040818193952.GA27639@nevyn.them.org> <4123B62C.6060703@redhat.com> <4135E722.2030401@gnu.org> <41360E6D.5040702@redhat.com> <41362333.nail1N211MB10@mindspring.com> In-Reply-To: <41362333.nail1N211MB10@mindspring.com> Content-Type: multipart/mixed; boundary="------------080609090005080003020304" X-SW-Source: 2004-09/txt/msg00027.txt.bz2 This is a multi-part message in MIME format. --------------080609090005080003020304 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1600 Michael Chastain wrote: > Jeff Johnston wrote: > >>Thanks. Patches committed, including fix to the testcase. > > > Uh, I haven't approved that fix. > > I wrote: > > If the test script accepts both old+new messages, and the new message is > not wildly more complex than the old message, then testing with the old > message alone is good enough for getting the test script approved. > Just pop out the new patch and say how / what system you tested on. > > You needed to send a fresh patch to gdb-patches, say how you tested it, > and then get it approved. I'm sorry if this wasn't clear from my message. > Sometimes I do write too colloquially. > > This is actually a live issue because the patch you committed has > a problem: > > -"Continuing.*y is 7.*warning: Temporarily disabling unloaded shared library breakpoints.*warning: breakpoint #.*Program exited normally." \ > -"continuing to end of program second time" > +"Continuing.*y is 7.*warning: Temporarily disabling breakpoints for.*unloadshr.sl.*Program exited normally." \ > +"continuing to end of program" > > Now there are two tests with the identical name "continuing to end > of program", which leads to confusion. > > Can you please: fix that; say which system you tested it on; > and submit a patch to gdb-patches? > Oops, my bad. Sorry about that. Tested on x86-linux, ia64-linux, x86_64-linux, s390-linux. Patch attached to fix problem above. 2004-09-01 Jeff Johnston * gdb.base/unload.exp: Fix so messages aren't duplicated. > Michael > --------------080609090005080003020304 Content-Type: text/plain; name="unload.patch3" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="unload.patch3" Content-length: 562 Index: gdb.base/unload.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/unload.exp,v retrieving revision 1.2 diff -u -p -r1.2 unload.exp --- gdb.base/unload.exp 1 Sep 2004 17:56:20 -0000 1.2 +++ gdb.base/unload.exp 1 Sep 2004 20:40:57 -0000 @@ -139,5 +139,5 @@ gdb_test "run" \ gdb_test "continue" \ "Continuing.*y is 7.*warning: Temporarily disabling breakpoints for.*unloadshr.sl.*Program exited normally." \ -"continuing to end of program" +"continuing to end of program second time" --------------080609090005080003020304--