From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29307 invoked by alias); 30 Aug 2004 20:59:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29298 invoked from network); 30 Aug 2004 20:59:18 -0000 Received: from unknown (HELO maynard.mail.mindspring.net) (207.69.200.243) by sourceware.org with SMTP; 30 Aug 2004 20:59:18 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by maynard.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1C1tFE-0002C3-00; Mon, 30 Aug 2004 16:59:16 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 7CFAC4B102; Mon, 30 Aug 2004 16:59:39 -0400 (EDT) Date: Mon, 30 Aug 2004 20:59:00 -0000 From: Michael Chastain To: manjo@austin.ibm.com Subject: Re: [patch/testsuite] gdb_file_cmd: enhance return value Cc: gdb-patches@sources.redhat.com Message-ID: <4133953A.nailGLM1C8JMN@mindspring.com> References: <412FC668.nailENL1TNTCG@mindspring.com> <41311C61.nailEAF11S0DZ@mindspring.com> In-Reply-To: User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00777.txt.bz2 > Have you commited these changes to the testcase already? I just checked > out cvs -z9 -d :ext:manjo@sources.redhat.com:/cvs/src co src/gdb and I did > not see changes to the testcases. Am I checking out the correct tree?? You've got the right tree. I changed the callers only enough to work with the new return value of { "" } on success. I didn't do the { "" nodebug } part in the callers. I could have done that part too -- it would be less checkins to gdb overall and less work for you. But it felt kind of funny just taking over like that. So I didn't glom that part; I left that for you to do, to help bring up your skills more, build the gdb team, that kinda stuff. Michael