From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17667 invoked by alias); 27 Aug 2004 14:48:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17620 invoked from network); 27 Aug 2004 14:48:23 -0000 Received: from unknown (HELO smtp6.mindspring.com) (207.69.200.110) by sourceware.org with SMTP; 27 Aug 2004 14:48:23 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by smtp6.mindspring.com with esmtp (Exim 3.33 #1) id 1C0i1e-00028k-00; Fri, 27 Aug 2004 10:48:22 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id C13774B102; Fri, 27 Aug 2004 10:48:27 -0400 (EDT) Date: Fri, 27 Aug 2004 14:48:00 -0000 From: Michael Chastain To: manjo@austin.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [RFC] GDB testsuite patch. (revised version) Message-ID: <412F49BA.nailEDT11A0NY@mindspring.com> References: <41251A45.nail58D215HD7@mindspring.com> <4125BB8B.nailJWP1FZGHJ@mindspring.com> <20040825124945.GA25217@nevyn.them.org> <412C98BD.nail10P1YTPHK@mindspring.com> In-Reply-To: User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00737.txt.bz2 Ouch, copying the whole text of gdb_file_cmd is no good, either! That much duplicate code is bad. Here is my plan. gdb_file_cmd has a return value. None of the callers of gdb_file_cmd uses the return vale, except for gdb_load, which simply returns the same value. There are about 300 callers of gdb_load. Most of them don't use the return value either. The exceptions are: gdb.base/remote.exp gdb.base/sepdebug.exp # does not use the return value but it wants to gdb.gdb/complaints.exp gdb.gdb/observer.exp gdb.gdb/selftest.exp gdb.gdb/xfullpath.exp gdb.stabs/weird.exp # does not use the return value but it wants to lib/gdb.exp: proc gdb_run_cmd So, I will do some infrastructure work: I will make gdb_load return a better return value that includes more information, like a list with more status information: success indicator whatever sepdebug.exp is looking for whatever weird.exp is looking for indicator of whether debug symbols found or not While I am in there, I will see if I can get back any commonality with mi_gdb_file_cmd. But that's optional. I expect to commit the new gdb_file_cmd sometime on Saturday. After that, it will be easy for you to change gdb.gdb/*.exp to just use the new information in the return value from gdb_load. Michael 2004-08-26 Manoj Iyer