From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24781 invoked by alias); 27 Aug 2004 14:16:29 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24751 invoked from network); 27 Aug 2004 14:16:27 -0000 Received: from unknown (HELO smtp10.atl.mindspring.net) (207.69.200.246) by sourceware.org with SMTP; 27 Aug 2004 14:16:27 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by smtp10.atl.mindspring.net with esmtp (Exim 3.33 #1) id 1C0hWb-0001cV-00; Fri, 27 Aug 2004 10:16:17 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id ABB3B4B102; Fri, 27 Aug 2004 10:16:22 -0400 (EDT) Date: Fri, 27 Aug 2004 14:16:00 -0000 From: Michael Chastain To: ibr@ata.cs.hun.edu.tr, gdb-patches@sources.redhat.com Subject: Re: testcase for "absolute source" patch Message-ID: <412F4235.nailDKT1M7PGM@mindspring.com> References: <20040816144349.GB1509@ata.cs.hun.edu.tr> <412107B7.nailE7I1XJVIH@mindspring.com> <20040818130626.GB1411@ata.cs.hun.edu.tr> <4123763C.nailM3P11DT7E@mindspring.com> <20040818155324.GC1411@ata.cs.hun.edu.tr> <4123A736.nail5OO17XN7L@mindspring.com> <20040818220613.GA3143@ata.cs.hun.edu.tr> <4123E749.nail65Z1YIZ3O@mindspring.com> <20040826203603.GA18267@ata.cs.hun.edu.tr> In-Reply-To: <20040826203603.GA18267@ata.cs.hun.edu.tr> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00735.txt.bz2 The first time I run openp.exp, I get 4 non-PASS results: FAIL: gdb.base/openp.exp: openp s1-da (non-existent source, basename, find in /$cdir/basename) FAIL: gdb.base/openp.exp: openp s3-da (non-existent source, relative name, find in /$cdir/relative) FAIL: gdb.base/openp.exp: openp s4-da (non-existent source, in the current dir, find in /$cdir/basename) FAIL: gdb.base/openp.exp: openp s5-da (non-existent source, in the upper dir, find in /$cdir/relative) The second time I run openp.exp, it crashes and burns: Running /berman/fsf/_current_/source/gdb/HEAD/src/gdb/testsuite/gdb.base/openp.exp ... gdb compile failed, gcc: /tmp/migbat-testgdb-BqdGwxc7/test/gdb.base/openp/subdir/src/openp.c: No such file or directory WARNING: Testcase compile failed. ERROR: (timeout) GDB never initialized after 10 seconds. UNRESOLVED: gdb.base/openp.exp: openp b1+ (existing binary, basename) ... I suspect this line is at fault: remote_exec host "mv $srcdir/$subdir/$testname.c $srcfile" $srcdir is read-only. More feedback: . add a ChangeLog entry . add some code at the top to check for build != host if { [is_remote host] } { unresolved "This test script does not work on a remote host." return -1 } . since the script does not work with build != host, you can simplify all the "remote_exec host" calls to TCL primitives that run on the build machine anyways. Like: "file mkdir ...". Your choice. If you like "remote_exec host", you can keep it. . error checking on every external call. Sometimes directory creation does fail. That's all the time I have for this round. I still haven't really gotten into the substantive part of the script yet. :( Michael