From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2131 invoked by alias); 27 Aug 2004 11:23:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2118 invoked from network); 27 Aug 2004 11:23:03 -0000 Received: from unknown (HELO barry.mail.mindspring.net) (207.69.200.25) by sourceware.org with SMTP; 27 Aug 2004 11:23:03 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by barry.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1C0eow-0007iO-00; Fri, 27 Aug 2004 07:23:02 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 7791B4B102; Fri, 27 Aug 2004 07:23:07 -0400 (EDT) Date: Fri, 27 Aug 2004 11:23:00 -0000 From: Michael Chastain To: msnyder@redhat.com Subject: Re: [rfa/testsuite/threads] fix gcc signed/unsigned warning Cc: gdb-patches@sources.redhat.com Message-ID: <412F199A.nailK3I21D250@mindspring.com> References: <412E17EE.nail6CX1NP8LE@mindspring.com> <412E9F3A.4010200@redhat.com> In-Reply-To: <412E9F3A.4010200@redhat.com> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00726.txt.bz2 Michael Snyder wrote: > But if you want to just do this, it's OK with me. Yay, committed. > Well, it really looks to me as if either args should be > signed, or myp should be unsigned. The test will work > either way, although signed would "feel" safer. I fooled around with this. I couldn't find something that was type-safe and felt exactly like the old test. So I decided "one thing at a time" -- first make it compile like it did with old compilers, then later, fix the signed/unsigned muddle. I've filed a PR for the signed/unsigned part. === 2004-08-26 Michael Chastain Fix PR testsuite/1735. * gdb.threads/schedlock.c (thread_function): Add a cast to suppress a gcc warning. * gdb.threads/thread-specific.c (thread_function): Likewise.