From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30363 invoked by alias); 23 Aug 2004 22:35:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30348 invoked from network); 23 Aug 2004 22:35:49 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 23 Aug 2004 22:35:49 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7NMZne1002750 for ; Mon, 23 Aug 2004 18:35:49 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7NMZma14186; Mon, 23 Aug 2004 18:35:48 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i7NMZese031430; Mon, 23 Aug 2004 18:35:48 -0400 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 3537180001E; Mon, 23 Aug 2004 18:35:40 -0400 (EDT) Message-ID: <412A713C.1020004@redhat.com> Date: Mon, 23 Aug 2004 22:35:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Michael Chastain Cc: gdb-patches@sources.redhat.com, eliz@gnu.org, drow@false.org Subject: Re: [RFA]: Fix for pending breakpoints in manually loaded/unloaded shlibs References: <41191D71.60204@redhat.com> <20040811171203.GA4152@nevyn.them.org> <411A7D97.50104@redhat.com> <20040818135621.GA26257@nevyn.them.org> <4123AC6E.8000300@redhat.com> <20040818193952.GA27639@nevyn.them.org> <4123B62C.6060703@redhat.com> <412A62A6.3010806@redhat.com> <412A6B08.nailD8G118X9H@mindspring.com> In-Reply-To: <412A6B08.nailD8G118X9H@mindspring.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00635.txt.bz2 Michael Chastain wrote: > The test script is not quite okay. > > The test script should match the output from the last released gdb, > gdb 6.2, as well as the current gdb. > The test should behave the same because the gdb code that generates the message it is checking hasn't been committed yet. On retrospect, perhaps I should not have committed the testcase in with this particular check in place (the test itself is a valid one regardless). There has been some questions regarding whether I should be using an observer or not. Knowing that, do I still need to do the following or can I check the change I attached in once I get final approval on the code and most importantly, the message to be issued? > When I compare gdb 6.2 with gdb HEAD, or with gdb 6.2.91 (when it > comes out), I use the same current test suite with both the old > and new gdb's. I can't compare: > > (gdb 6.2, suite 6.2) > (gdb 6.2.91, suite 6.2.91) > > ... because there are thousands of new tests and test name changes. > So I have to compare: > > (gdb 6.2, suite 6.2.91) > (gdb 6.2.91, suite 6.2.91) > > So it helps me if the test suite continues to match > the messages from the last released gdb. > > If you're curious, you can see some of these comparison tables here: > > http://www.shout.net/~mec/sunday/2004-08-18/Compare-by-gdb-branch-HEAD.html > > === > > You can do this either by fuzzing the pattern up with some wild cards, > or with the "(...|...)" construct, or by using a gdb_test_multiple > with one arm for the old output and one arm for the new. > Personally I would go for gdb_test_multiple: > > set name "continuing to end of program" > gdb_test_multiple "continue" $name { > -re "Continuing.*y is 7.*warning: ... disabling unloaded shared library breakpoints ....*$gdb_prompt $" { > # old gdb 6.2 > pass $name > } > -re "Continuing.*y is 7.*warning: ... disabling breakpoints for.*unloadshr.sl.* ... $gdb_prompt $" { > # new gdb HEAD 2004-08-23 > pass $name > } > } > > Also, what system did you test on? > > === > > 2004-08-23 Jeff Johnston > > * gdb.base/unload.exp: Fix expected warning message to match > latest format. > >