From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13370 invoked by alias); 23 Aug 2004 22:09:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13296 invoked from network); 23 Aug 2004 22:09:06 -0000 Received: from unknown (HELO mclean.mail.mindspring.net) (207.69.200.57) by sourceware.org with SMTP; 23 Aug 2004 22:09:06 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by mclean.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BzMzp-0005ei-00; Mon, 23 Aug 2004 18:08:58 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 105194B102; Mon, 23 Aug 2004 18:09:12 -0400 (EDT) Date: Mon, 23 Aug 2004 22:09:00 -0000 From: Michael Chastain To: jjohnstn@redhat.com Subject: Re: [RFA]: Fix for pending breakpoints in manually loaded/unloaded shlibs Cc: gdb-patches@sources.redhat.com, eliz@gnu.org, drow@false.org Message-ID: <412A6B08.nailD8G118X9H@mindspring.com> References: <41191D71.60204@redhat.com> <20040811171203.GA4152@nevyn.them.org> <411A7D97.50104@redhat.com> <20040818135621.GA26257@nevyn.them.org> <4123AC6E.8000300@redhat.com> <20040818193952.GA27639@nevyn.them.org> <4123B62C.6060703@redhat.com> <412A62A6.3010806@redhat.com> In-Reply-To: <412A62A6.3010806@redhat.com> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00634.txt.bz2 The test script is not quite okay. The test script should match the output from the last released gdb, gdb 6.2, as well as the current gdb. When I compare gdb 6.2 with gdb HEAD, or with gdb 6.2.91 (when it comes out), I use the same current test suite with both the old and new gdb's. I can't compare: (gdb 6.2, suite 6.2) (gdb 6.2.91, suite 6.2.91) ... because there are thousands of new tests and test name changes. So I have to compare: (gdb 6.2, suite 6.2.91) (gdb 6.2.91, suite 6.2.91) So it helps me if the test suite continues to match the messages from the last released gdb. If you're curious, you can see some of these comparison tables here: http://www.shout.net/~mec/sunday/2004-08-18/Compare-by-gdb-branch-HEAD.html === You can do this either by fuzzing the pattern up with some wild cards, or with the "(...|...)" construct, or by using a gdb_test_multiple with one arm for the old output and one arm for the new. Personally I would go for gdb_test_multiple: set name "continuing to end of program" gdb_test_multiple "continue" $name { -re "Continuing.*y is 7.*warning: ... disabling unloaded shared library breakpoints ....*$gdb_prompt $" { # old gdb 6.2 pass $name } -re "Continuing.*y is 7.*warning: ... disabling breakpoints for.*unloadshr.sl.* ... $gdb_prompt $" { # new gdb HEAD 2004-08-23 pass $name } } Also, what system did you test on? === 2004-08-23 Jeff Johnston * gdb.base/unload.exp: Fix expected warning message to match latest format.