From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19401 invoked by alias); 23 Aug 2004 20:40:19 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19379 invoked from network); 23 Aug 2004 20:40:18 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 23 Aug 2004 20:40:18 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7NKeIe3003698 for ; Mon, 23 Aug 2004 16:40:18 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7NKeCa03813; Mon, 23 Aug 2004 16:40:13 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9E4232B9D; Mon, 23 Aug 2004 16:39:04 -0400 (EDT) Message-ID: <412A55E8.3060100@gnu.org> Date: Mon, 23 Aug 2004 20:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040801 MIME-Version: 1.0 To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: Support libthread_db xregs interface References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00628.txt.bz2 > This patch adds support to GDB for the libthread_db 'xregs' functions, > which allow registers not present in 'gregset_t' or 'fpregset_t' to be > passed through libthread_db. The contents of the 'xregs' register set > is not specified by GDB; the libthread_db client can specify whatever > size it likes, and libthread_db will pass it through unchanged. > > I'll post a second patch which defines an 'xregs' register set for the > PowerPC E500 SPE registers. > > At present, the GNU C library's libthread_db's xregs functions are > stubbed out; I also have a patch to glibc to implement them, which > I'll be submitting. If GDB loads a libthread_db that does not > implement the xregs functions, this patch handles that case. > > These have all been tested on E500 powerpc-unknown-linux-gnu and on > i686-pc-linux-gnu (where they should have no effect). > > This patch should allow us to remove the call to dummy_sse_values in > supply_fpregset. Not that that call is especially necessary or > helpful at the moment anyway, as far as I can tell. > > This patch was originally posted here: > http://sources.redhat.com/ml/gdb-patches/2004-03/msg00571.html > > I believe it's been revised to implement the suggestions made there. [...] > + v:=:const struct regset *:xregs_regset:::0 Mark's regset change added both the "regset.h" object and the regset_from_core_section architecture method. They, together, replace the old *-nat.c:fill_regset et.al. calls. Can we implement the equivalent here for ptrace/thread-db? -- Instead of: > + if (! warned_xregs_not_implemented) > + { > + warning ("thread debugging library is too old to access " > + "%s registers.", > + gdbarch_xregs_name (current_gdbarch)); can we use "complaint". That "thread" should be "Thread". -- > + v:=:int:xregs_size:::0 > + v:=:const char *:xregs_name:::0 I gather these were fields in the original xreg_desc object but are missing from the "regset"? Should these, instead be added to the regset, or a new object extending regset created? Andrew