From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26553 invoked by alias); 12 Dec 2019 19:54:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26541 invoked by uid 89); 12 Dec 2019 19:54:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=mandate, HX-Spam-Relays-External:Sendmail, H*RU:Sendmail, completing X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 12 Dec 2019 19:54:21 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id xBCJsEhX022273 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 12 Dec 2019 14:54:19 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca xBCJsEhX022273 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1576180459; bh=8mGBOmuLuiXQ/WBsITPX+5lwxdQbXIieW+VDSuDodLk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=kOrMUetwAXZ//+Yzp9JXOFezJy66LUILDOVdO4Cudw8TIyw0OVNfwY4TQbJvg65Nw QcYEtP0I6TxwbIjEiGQ//olWpzOSlJYD3v1uJXnzP9Zr7H1XfUqVRC9KNgwx6xu3nC 91b4QqJRiw+FdmhVw4GZFeeQcVJa2jS4YQZf6w8s= Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 1B5BA1E573; Thu, 12 Dec 2019 14:54:14 -0500 (EST) Subject: Re: [PATCH 2/2] Fix indentation in jit.c To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20191211063732.1043487-1-simon.marchi@polymtl.ca> <20191211063732.1043487-2-simon.marchi@polymtl.ca> <8736dp5pwq.fsf@tromey.com> From: Simon Marchi Message-ID: <41207875-8bea-127d-9b4d-0daa0f50eaa5@polymtl.ca> Date: Thu, 12 Dec 2019 19:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <8736dp5pwq.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00537.txt.bz2 On 2019-12-12 2:01 p.m., Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Many places in this file use spaces only for indentation. Fix them to > Simon> conform to GNU style. > > Simon> gdb/ChangeLog: > > Simon> * jit.c: Fix indentation, replace spaces with tabs where > Simon> applicable. > > Is this really our policy? I thought others (Joel maybe?) had argued > for no tabs in the past, or that maybe we settled on a "don't care" > approach. Hmm I'm confused. Doesn't the GNU style mandate using tabs + spaces for indentation? Using a tab for whole groups of 8 columns, then completing with spaces? I have never heard that we would accept spaces only. Now I can't find the reference in the GNU coding standards, so I am wondering if I just imagined this all these years. Simon