From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18471 invoked by alias); 15 Aug 2004 07:04:10 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18462 invoked from network); 15 Aug 2004 07:04:09 -0000 Received: from unknown (HELO maynard.mail.mindspring.net) (207.69.200.243) by sourceware.org with SMTP; 15 Aug 2004 07:04:09 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by maynard.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1BwF3o-0006yl-00; Sun, 15 Aug 2004 03:04:08 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id DAA094B102; Sun, 15 Aug 2004 03:04:10 -0400 (EDT) Date: Sun, 15 Aug 2004 07:04:00 -0000 From: Michael Chastain To: kettenis@chello.nl, gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFA] Testsuite improvements for non-decr_pc_after_break i386 Message-ID: <411F0AEA.nail9Q211HV3N@mindspring.com> References: <200408142006.i7EK6bEE001195@elgar.kettenis.dyndns.org> In-Reply-To: <200408142006.i7EK6bEE001195@elgar.kettenis.dyndns.org> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00518.txt.bz2 This patch is approved. I proofread it. I also tested it on native i686-pc-linux-gnu, which is a no-adjust platform ($eip points after the breakpoint). I turned it into an adjust platform with this: gdb_test "set \$pc = \$pc - 1" "" "decr pc" ... and the logic works. Michael C === Index: testsuite/ChangeLog from Mark Kettenis * gdb.arch/i386-prologue.exp (skip_breakpoint): New function. Use it to skip the breakpoints encoded in the inline assembly.