Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Chastain <mec.gnu@mindspring.com>
To: cagney@gnu.org
Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com
Subject: Re: [rfc/testsuite/mi] use gdb_get_line_number
Date: Wed, 11 Aug 2004 18:53:00 -0000	[thread overview]
Message-ID: <411A6B1A.nailOZS31UHES@mindspring.com> (raw)
In-Reply-To: <411A609D.3080306@gnu.org>

Andrew Cagney <cagney@gnu.org> wrote:
ac> Yea, not really. basics.c:callee3 && basics.callee3.prolog?

Okay, I'll take all the line numbers out of the test names, somehow.

mec> # Locate line numbers in basics.c.
mec> set line_callee4        [expr [gdb_get_line_number "callee4 ("]]
mec> set line_callee4_plus_2 [expr [gdb_get_line_number "callee4 ("] + 2]

ac> I'm wondering if the latter should be called:
ac>	line_callee4_past_prologue

Now that you mention it, the "*_plus_2" names look dorky.

Perhaps:

  set line_callee4_head [expr [gdb_get_line_number "callee4 ("]]
  set line_callee4_body [expr [gdb_get_line_number "callee4 ("] + 2]

I like "line_foo_body", but "line_foo_head" sounds a little funny.

Perhaps "line_foo_definition" or "line_foo_defn".

I don't like "line_foo_prologue" because these are lines in the
source file, and the prologue is a property of the object code.

I'll work up another RFC.

Michael C


  reply	other threads:[~2004-08-11 18:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-10  8:45 Michael Chastain
2004-08-11 18:08 ` Andrew Cagney
2004-08-11 18:53   ` Michael Chastain [this message]
2004-08-11 20:14     ` Andrew Cagney
2004-08-11 22:17       ` Michael Chastain
2004-08-11 23:00         ` Andrew Cagney
2004-08-12 12:03           ` Michael Chastain
2004-08-12 12:12             ` Andrew Cagney
2004-08-12 12:45               ` Michael Chastain
2004-08-11 19:22   ` Michael Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=411A6B1A.nailOZS31UHES@mindspring.com \
    --to=mec.gnu@mindspring.com \
    --cc=cagney@gnu.org \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox