From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32080 invoked by alias); 9 Aug 2004 19:47:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32058 invoked from network); 9 Aug 2004 19:47:53 -0000 Received: from unknown (HELO smtp10.atl.mindspring.net) (207.69.200.246) by sourceware.org with SMTP; 9 Aug 2004 19:47:53 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by smtp10.atl.mindspring.net with esmtp (Exim 3.33 #1) id 1BuG7b-0005hX-00; Mon, 09 Aug 2004 15:47:51 -0400 Received: from mindspring.com (localhost [127.0.0.1]) by berman.michael-chastain.com (Postfix) with SMTP id 8DEA54B102; Mon, 9 Aug 2004 15:47:54 -0400 (EDT) Date: Mon, 09 Aug 2004 19:47:00 -0000 From: Michael Chastain To: kettenis@chello.nl Subject: Re: [patch/testsuite] lib/gdb.exp: native tcl gdb_get_line_number Cc: gdb-patches@sources.redhat.com Message-ID: <4117D4E9.nailNML1MZER2@mindspring.com> References: <4116516C.nailLPL1BAKH4@mindspring.com> <200408091755.i79Hta9D038666@elgar.kettenis.dyndns.org> In-Reply-To: <200408091755.i79Hta9D038666@elgar.kettenis.dyndns.org> User-Agent: nail 10.8 6/28/04 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00334.txt.bz2 Mark Kettenis wrote: > This causes problems if you configure using a relative pathname, i.e. > > ../src/configure --enable-gdb-build-warnings=,-Werror Oof. I forgot all about relative pathnames. > The attached patch fixes things for me, but can somebody please check > whether i've escaped the dot correctly? I'm going to think about this problem a bit. I don't really like that compatibility kludge in the first place, and I'd rather bust some heads in the callers and de-kludge this rather then en-kludge it some more. So this patch is not approved. (If I don't get the problem fixed pretty quick then I'll have to accept it though). Which files are causing problems on your system? On my system, the intersection between gdb_get_line_number and ${srcfile*} with a "/" in them is: gdb.cp/ctti.exp gdb.cp/m-static.exp So I would have to change two callers. In the long run I want to go further and change all the callers to explicitly specify a filename and then kill off the kludge. But that's not suitable for right now. Michael C