>>>> + format = NULL; >>>> + if (format == NULL) >>>> + error ("This GDB does not support %d-bit floating-point values.", >>>> + len & TARGET_CHAR_BIT); >>>> + return format; >>>> } >> >> >> >> Why do you use a variable? wouldn't have it been simpler to >> add one line at the end like this: >> >> error ("bla bla bla"); >> return NULL; /* Will never be reached. */ > > > And: > if (TARGET_FLOAT_FORMAT != NULL && len * TARGET_CHAR_BIT == TARGET_FLOAT_BIT) > return TARGET_FLOAT_FORMAT; > ... > else > error ("blah, blah"); > I don't trust *_FORMAT to be non-NULL. By deleting architecture methods of my PPC config I reproduced the crash (outch!). I've committed the attached to both the mainline and branch (the error message was tweaked slightly). Andrew