From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34847-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 25037 invoked by alias); 4 Aug 2004 04:09:45 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 25028 invoked from network); 4 Aug 2004 04:09:44 -0000
Received: from unknown (HELO blount.mail.mindspring.net) (207.69.200.226)
  by sourceware.org with SMTP; 4 Aug 2004 04:09:44 -0000
Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com)
	by blount.mail.mindspring.net with esmtp (Exim 3.33 #1)
	id 1BsD5x-0001X6-00; Wed, 04 Aug 2004 00:09:41 -0400
Received: from mindspring.com (localhost [127.0.0.1])
	by berman.michael-chastain.com (Postfix) with SMTP
	id A70DC4B102; Wed,  4 Aug 2004 00:10:03 -0400 (EDT)
Date: Wed, 04 Aug 2004 04:09:00 -0000
From: Michael Chastain <mec.gnu@mindspring.com>
To: gdb-patches@sources.redhat.com, cagney@gnu.org
Subject: Re: [rfa] Cleanup store.exp
Message-ID: <4110619B.nailCV2114VMQ@mindspring.com>
References: <411040EB.3060904@gnu.org>
In-Reply-To: <411040EB.3060904@gnu.org>
User-Agent: nail 10.8 6/28/04
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-08/txt/msg00078.txt.bz2

Andrew Cagney <cagney@gnu.org> wrote:
> This gets rid of the duplicate test messages in sore.exp.  Tested on FC2.
> m'kay.

This patch is approved.

I'm particularly happy with this bit:

  -    gdb_test "print l" " = ${l}" "print old l - ${t}"
  -    gdb_test "print r" " = ${r}" "print old r - ${t}"
  +    gdb_test "print l" " = ${l}" \
  +	"${prefix}; print old l, expecting ${l}"
  +    gdb_test "print r" " = ${r}" \
  +	"${prefix}; print old r, expecting ${r}"

Maybe it's just me, but when I saw "print old l - int",
I parsed it as "print old l minus int".  So I'm glad to see
the dash character go away.

Michael C

===

2004-08-03  Andrew Cagney  <cagney@gnu.org>

	* gdb.base/store.exp: Update copyright.
	(check_set, up_set, check_struct, up_struct): Add a prefix to test
	names, do not import gdb_prompt.