From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18559 invoked by alias); 4 Aug 2004 01:43:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18552 invoked from network); 4 Aug 2004 01:43:49 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 4 Aug 2004 01:43:49 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i741hie3002644 for ; Tue, 3 Aug 2004 21:43:44 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i741hca32388; Tue, 3 Aug 2004 21:43:38 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id EAEDB2BA0; Tue, 3 Aug 2004 21:20:51 -0400 (EDT) Message-ID: <411039F3.1020102@gnu.org> Date: Wed, 04 Aug 2004 01:43:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040801 MIME-Version: 1.0 To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/RFC] fix problems with unwinder on mips-irix References: <20040723011059.GI20596@gnat.com> <410994BD.5040506@gnu.org> <20040803044358.GA18163@gnat.com> In-Reply-To: <20040803044358.GA18163@gnat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00073.txt.bz2 > Andrew, > > >>>> >2004-07-22 Joel Brobecker >>>> > >>>> > * mips-tdep.c (mips_mdebug_frame_cache): Minor reformatting. >>>> > (set_saved_reg_info): New function. >>>> > (mips32_heuristic_proc_desc): Compute the procedure descriptor >>>> > PROC_REG_OFFSET. >>>> > >> >>> >>> It's time to cut our losses and split the mdebug and heuristic cases. >>> Lets work through this change after I've done that. > > > I am sorry. I didn't have time to follow very well your recent changes > to the mips unwinders. Is it time for me to come back to this issue, > or do you think I should wait some more? If you've the time, please do. Two key things to know: - with three unwinders handling three different cases previously handled by one, there's a lot of dead code paths. For instance, mips32_heuristic_proc_desc is now only called by mips_insn32_frame_cache and hence can be inlined there, making it possible for your problem to be solved more locally. - I'm interested in a brutal overhaul of an unwinder, not a small tweak :-) >>> In the mean time, can I encourage you to look at the s390 and it's >>> stub-unwinder - the MIPS desperatly needs one of these (and it is >>> something that can be wipped up in isolation). To see where its needed >>> do a STEPI into shlib trampoline code. > > > I would love to, IRIX looks like a fun platform to play with, but I am > a bit time-starved right now. Hopefully in september. I've added a stub unwinder. Andrew