From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9913 invoked by alias); 1 Aug 2004 18:28:28 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9906 invoked from network); 1 Aug 2004 18:28:27 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 1 Aug 2004 18:28:27 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i71ISRe3009402 for ; Sun, 1 Aug 2004 14:28:27 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i71ISNa17500; Sun, 1 Aug 2004 14:28:24 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1EA732B9D; Sun, 1 Aug 2004 14:28:18 -0400 (EDT) Message-ID: <410D3641.1000702@gnu.org> Date: Sun, 01 Aug 2004 18:28:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040801 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com Subject: [rfa] Stop dump.exp getting out-of-sync Content-Type: multipart/mixed; boundary="------------070205080700030201080100" X-SW-Source: 2004-08/txt/msg00013.txt.bz2 This is a multi-part message in MIME format. --------------070205080700030201080100 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 444 Hello, This patch modifies dump.exp's capture_value function so that it: - slurps output up to "(gdb)" Stop GDB and dejagnu getting out-of-sync - allow `invalid memory access' as a `value' Stop double fail from an invalid value also not matching the old value. Both of these are to stop dump.exp loosing the plot when gdb is broken. Tested on mips-sim (it no longer hangs for several hours :-^); and NetBSD/PPC, it passes. m'kay? Andrew --------------070205080700030201080100 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 6683 2004-08-01 Andrew Cagney Fix PR testsuite/1729. * gdb.base/dump.exp: Add test name to callers of capture_value, do not use capture_value with value 4. (capture_value): Add optional test name parameter. (test_reload_saved_value, test_restore_saved_value): Use $msg as the prefix, pass to capture_value. Index: gdb.base/dump.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/dump.exp,v retrieving revision 1.6 diff -p -u -r1.6 dump.exp --- gdb.base/dump.exp 18 Feb 2004 04:15:46 -0000 1.6 +++ gdb.base/dump.exp 1 Aug 2004 18:16:23 -0000 @@ -113,18 +113,26 @@ make_dump_file "dump tekhex val intarr1. make_dump_file "dump tekhex val intstr1.tekhex intstruct" \ "dump struct as value, tekhex" -proc capture_value { expression } { +proc capture_value { expression args } { global gdb_prompt global expect_out set output_string "" - send_gdb "print ${expression}\n" - gdb_expect { - -re ".*\[\r\n\]+.\[0123456789\]+ = (\[^\r\n\]+).*$gdb_prompt $" { - set output_string $expect_out(1,string) + if {[llength $args] > 0} { + # Convert $args into a simple string. + set test "[join $args]; capture $expression" + } { + set test "capture $expression" + } + gdb_test_multiple "print ${expression}" "$test" { + -re "\\$\[0-9\]+ = (\[^\r\n\]+).*$gdb_prompt $" { + set output_string "$expect_out(1,string)" + pass "$test" } - default { - fail "capture_value failed on $expression." + -re "(Cannot access memory at address \[^\r\n\]+).*$gdb_prompt $" { + # Even a failed value is valid + set output_string "$expect_out(1,string)" + pass "$test" } } return $output_string @@ -182,13 +190,15 @@ gdb_file_cmd ${binfile} # Reload saved values one by one, and compare. -if { ![string compare $array_val [capture_value "intarray"]] } then { +if { ![string compare $array_val \ + [capture_value "intarray" "file binfile"]] } then { fail "start with intarray un-initialized" } else { pass "start with intarray un-initialized" } -if { ![string compare $struct_val [capture_value "intstruct"]] } then { +if { ![string compare $struct_val \ + [capture_value "intstruct" "file binfile"]] } then { fail "start with intstruct un-initialized" } else { pass "start with intstruct un-initialized" @@ -198,10 +208,11 @@ proc test_reload_saved_value { filename global gdb_prompt gdb_file_cmd $filename - if { ![string compare $oldval [capture_value $newval]] } then { - pass $msg + if { ![string compare $oldval \ + [capture_value $newval "$msg"]] } then { + pass "$msg; value restored ok" } else { - fail $msg + fail "$msg; value restored ok" } } @@ -209,13 +220,13 @@ proc test_restore_saved_value { restore_ global gdb_prompt gdb_test "restore $restore_args" \ - "Restoring .*" \ - "Restore command, $msg" - - if { ![string compare $oldval [capture_value $newval]] } then { - pass "Restored value, $msg" + "Restoring .*" \ + "$msg; file restored ok" + if { ![string compare $oldval \ + [capture_value $newval "$msg"]] } then { + pass "$msg; value restored ok" } else { - fail "Restored value, $msg" + fail "$msg; value restored ok" } } @@ -268,13 +279,15 @@ if { ! [ runto_main ] } then { gdb_suppress_entire_file "Program failed to run, so remaining tests in this file will automatically fail." } -if { ![string compare $array_val [capture_value "intarray"]] } then { +if { ![string compare $array_val \ + [capture_value "intarray" "load binfile"]] } then { fail "start with intarray un-initialized, runto main" } else { pass "start with intarray un-initialized, runto main" } -if { ![string compare $struct_val [capture_value "intstruct"]] } then { +if { ![string compare $struct_val \ + [capture_value "intstruct" "load binfile"]] } then { fail "start with intstruct un-initialized, runto main" } else { pass "start with intstruct un-initialized, runto main" @@ -420,8 +433,7 @@ if ![string compare $is64bitonly "no"] t gdb_test "print zero_all ()" "" test_restore_saved_value "intarr1.srec 0 $element3_start $element4_start" \ - "array partial, srec" \ - [capture_value "4"] "intarray\[3\]" + "array partial, srec" 4 "intarray\[3\]" gdb_test "print intarray\[2\] == 0" " = 1" "element 2 not changed - 1" gdb_test "print intarray\[4\] == 0" " = 1" "element 4 not changed - 1" @@ -429,8 +441,7 @@ if ![string compare $is64bitonly "no"] t gdb_test "print zero_all ()" "" test_restore_saved_value "intarr1.ihex 0 $element3_start $element4_start" \ - "array partial, ihex" \ - [capture_value "4"] "intarray\[3\]" + "array partial, ihex" 4 "intarray\[3\]" gdb_test "print intarray\[2\] == 0" " = 1" "element 2 not changed - 2" gdb_test "print intarray\[4\] == 0" " = 1" "element 4 not changed - 2" @@ -438,8 +449,7 @@ if ![string compare $is64bitonly "no"] t gdb_test "print zero_all ()" "" test_restore_saved_value "intarr1.tekhex 0 $element3_start $element4_start" \ - "array partial, tekhex" \ - [capture_value "4"] "intarray\[3\]" + "array partial, tekhex" 4 "intarray\[3\]" gdb_test "print intarray\[2\] == 0" " = 1" "element 2 not changed - 3" gdb_test "print intarray\[4\] == 0" " = 1" "element 4 not changed - 3" @@ -449,8 +459,7 @@ gdb_test "print zero_all ()" "" test_restore_saved_value \ "intarr1.bin binary $array_start $element3_offset $element4_offset" \ - "array partial, binary" \ - [capture_value "4"] "intarray\[3\]" + "array partial, binary" 4 "intarray\[3\]" gdb_test "print intarray\[2\] == 0" " = 1" "element 2 not changed - 4" gdb_test "print intarray\[4\] == 0" " = 1" "element 4 not changed - 4" @@ -461,8 +470,7 @@ if ![string compare $is64bitonly "no"] t # restore with expressions test_restore_saved_value \ "intarr3.srec ${array2_start}-${array_start} &intarray\[3\] &intarray\[4\]" \ - "array partial with expressions" \ - [capture_value "4"] "intarray2\[3\]" + "array partial with expressions" 4 "intarray2\[3\]" gdb_test "print intarray2\[2\] == 0" " = 1" "element 2 not changed, == 4" gdb_test "print intarray2\[4\] == 0" " = 1" "element 4 not changed, == 4" @@ -471,4 +479,3 @@ if ![string compare $is64bitonly "no"] t # clean up files remote_exec build "rm -f intarr1.bin intarr1b.bin intarr1.ihex intarr1.srec intarr1.tekhex intarr2.bin intarr2b.bin intarr2.ihex intarr2.srec intarr2.tekhex intstr1.bin intstr1b.bin intstr1.ihex intstr1.srec intstr1.tekhex intstr2.bin intstr2b.bin intstr2.ihex intstr2.srec intstr2.tekhex intarr3.srec" - --------------070205080700030201080100--