From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53200 invoked by alias); 9 May 2018 14:43:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53158 invoked by uid 89); 9 May 2018 14:43:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1443 X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 May 2018 14:43:24 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0BE68185336; Wed, 9 May 2018 14:43:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B3B010B2B45; Wed, 9 May 2018 14:43:21 +0000 (UTC) Subject: Re: [PATCH v2] gdb: xtensa: handle privileged registers To: Max Filippov , gdb-patches@sourceware.org References: <20180507171121.7746-1-jcmvbkbc@gmail.com> Cc: Woody LaRue From: Pedro Alves Message-ID: <40e66129-0691-2519-00ac-0bc7009c06b6@redhat.com> Date: Wed, 09 May 2018 14:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180507171121.7746-1-jcmvbkbc@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-05/txt/msg00197.txt.bz2 Thanks for the updated patch with the rationale in the commit log. That helps. On 05/07/2018 06:11 PM, Max Filippov wrote: > xtensa GDB may be used with both bare-metal and linux-based > applications. In case of bare-metal application gdbserver is able to > provide information about all CPU registers: both unprivileged and > privileged. In case of linux-based application only a small subset of > privileged state is available. Currently xtensa GDB only expects > unprivileged registers in 'g' packets and it fails to communicate with > server that sends both privileged and unprivileged registers. > > Allow bare-metal xtensa GDB to deal with both privileged and > unprivileged registers by initializing tdep->num_regs with the total > number of target CPU registers. Keep linux-based xtensa GDB > functionality as is by copying tdep->num_nopriv_regs to tdep->num_regs. > > gdb/ > 2018-05-07 Max Filippov > > * xtensa-linux-tdep.c (xtensa-tdep.h): New include. > (xtensa_linux_init_abi): Limit tdep->num_regs by > tdep->num_nopriv_regs. > * xtensa-tdep.c (xtensa_derive_tdep): Calculate > tdep->num_nopriv_regs and only copy it to tdep->num_regs if it's > not initialized. I have a feeling that this would be best address with xml target descriptions, but I really don't know enough about xtensa to say for sure. This is OK with me as is. Thanks, Pedro Alves