From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FgBNOKC4jGiOpQEAWB0awg (envelope-from ) for ; Fri, 01 Aug 2025 08:52:48 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Eyiu4bQd; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D4EDD1E102; Fri, 1 Aug 2025 08:52:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B1441E091 for ; Fri, 1 Aug 2025 08:52:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E30E13858422 for ; Fri, 1 Aug 2025 12:52:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E30E13858422 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=suse.com header.i=@suse.com header.a=rsa-sha256 header.s=google header.b=Eyiu4bQd Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id E0A373858D1E for ; Fri, 1 Aug 2025 12:50:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0A373858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0A373858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::632 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754052648; cv=none; b=dlg7NmoqDf/rmHgl+mjWdTQ/qz2vqWfF/nVr1JxMphBF5uapP4Vu8wPyqXwptcv3slpl/xv1A4GXqlh7gL5NIYx3k7jb5xrrRNKIejTd4z+racJE6QUnscEqh5fO+COTJRDn7vC/cFTIOXkPpFKGydEuw7WRSYWZMhLuSOv6ANM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1754052648; c=relaxed/simple; bh=NMVVXDK4cXz2b//1Umi6m9e0aAgy6XC6YKzWAHaY450=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=j39BY87fOmRESVx1BRvKHI9ygIpZM9NexjTl3FPmK0rCln+f2htRXav+Yz0ImO1/QcXjKlkJgBpM9jMCLgbqgtmlwqUC3g+YG47yyn0wNlsQHQJImhGO56xkF/9MqIhZYBoNDkOLHgBSL943PswSOmfnWunARVcU6mqPK14lrWY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0A373858D1E Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-ae0bc7aa21bso176177066b.2 for ; Fri, 01 Aug 2025 05:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1754052646; x=1754657446; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=H/z3eY6/mFvFVR2FnY1V3qQycbQIVTWkjbsMZ38aatU=; b=Eyiu4bQd7nsKK4jsiGz21kNU71pz28zfu4yTs7Ljaj7n/qFryd95ENE5BEZLhSY4BA TirHBa/MOgEFkuSBOtWBw/xRfKKxk05Gho7p3c/c/JakZnoIn3yqCNe+83eGnwwDiVOk QYDjbHgJ0dFA7TTO0fAObVu1IRyvwbK2vYCTL38+vRGU8m66KOFW93hf6RAFIOhiU9NL vEGqEAUiduq3ipMJqVO4YYGalefmFBv1f3+XIfH9+VqWmxdA2kFGtqzOUI3ZA7TkAQrY 4pBFSn/scW8Cbtv85MbHNRj89PAuFjrx07mTl8sqlcGN/q7UQq4RSsuplNpCLb7LANgC Nh9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754052646; x=1754657446; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H/z3eY6/mFvFVR2FnY1V3qQycbQIVTWkjbsMZ38aatU=; b=tv5c6grzOPrqNe8Nq4lyyweDYtOXI7+mkZOyPHiNWOkoLNp/io4KmViuH1AjZbuNj7 rY/fEgpX0d1qbI+ZSbSC3skgjeFyOsVGQomZMgKhtpSDUXCRq0ItDQNoMeROpzO7BbrR Lr9rwJExSF3yl5TtyF0/jEWRcqq1YKmL+UzFU9OWCch8B8bRS0tJUMAyPywTF02PYnim jOa96mtLVbircBrTLyxMjewI5cr2zAzI2c8r2n4EsVYz544Jn4zFEqEPZD77B6LPhUKZ drHt0D00WDjaB9TipCscTSRcj5hKBusLxm6iVuLQXj5RbX3SdgHgneMfGviXF7jCWxL9 EjhA== X-Gm-Message-State: AOJu0Yz14nnOW79bQWr9nZsRO9zJ0Zf4+Vj7UYr87aWslFAb6UKrlu6r 752nKZoYo5IRo6pwn1Ts14HQUwdyvWCDcIAz2VOrYN5KE2qspvVnj7OjCr5mcUYBKM4YWUfE0XZ rrEo= X-Gm-Gg: ASbGncs8Q932v2Zvt/NPC9EwnbOsR51Xc4mEdra2VWPiNL0IgpWdyifQnXHfbDMHIWb 6D0+2WENhjdBLuI3yh95HDoHVQ/ss03Mx4Vededtl3iWT8ou8+RGRH2+gnOjUNwkuVgvgLejmbB vR8krv6UNI/n29AhrxteT4Cpx2HB/JcAa/4d53ZSD7bZZAr9TWCsbMvWN1pFwTPFwCCtiPBHJ5y /1jQlkXCaKF+GV9Cc3qoAoyRPR6Mz2X39w8qTkl886ozXw/kEyjomQgfCuSIkj6ZTGyP8DlFkss bv/ic6A9wFDP/FL4kdHXfKwmWwkGs5Mk7mA2QdYTTq2XH7dThkO3o/fS1IRuYFvYjMZyFqUrO3I CCJ21K1MclZgywsDiaYp+CCkpyT+TQ1o41wx1r+uSdyGga19cPH2jZqLUA2h1FwgaDHLVeyD+bf /iQvuVO5Y= X-Google-Smtp-Source: AGHT+IG88pMUSZdBOI1CpeVz9CBmBNxSSUb/zzjBRQxy2LNWzi4Wqkn3TK1XqQUKUjo3Rl2yM9vadw== X-Received: by 2002:a05:6000:401f:b0:3a5:39e9:928d with SMTP id ffacd0b85a97d-3b794f65518mr9041284f8f.0.1754052633691; Fri, 01 Aug 2025 05:50:33 -0700 (PDT) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-241e89a3acfsm42882755ad.146.2025.08.01.05.50.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Aug 2025 05:50:32 -0700 (PDT) Message-ID: <40e2adcd-5217-4beb-8d63-d1e265325376@suse.com> Date: Fri, 1 Aug 2025 14:50:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 33/44] gdb, dwarf, ze: add DW_OP_INTEL_regval_bits To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" , "binutils@sourceware.org" , "Aktemur, Tankut Baris" References: <20250801-upstream-intelgt-mvp-v3-0-59ce0f87075b@intel.com> <20250801-upstream-intelgt-mvp-v3-33-59ce0f87075b@intel.com> <1ab1209e-113e-4885-9e96-1b3756d60f67@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 01.08.2025 14:31, Metzger, Markus T wrote: >> On 01.08.2025 11:37, Tankut Baris Aktemur wrote: >>> --- a/include/dwarf2.def >>> +++ b/include/dwarf2.def >>> @@ -688,6 +688,10 @@ DW_OP (DW_OP_GNU_const_index, 0xfc) >>> /* The GNU variable value extension. >>> See http://dwarfstd.org/ShowIssue.php?issue=161109.2 . */ >>> DW_OP (DW_OP_GNU_variable_value, 0xfd) >>> +/* https://dwarfstd.org/ShowIssue.php?issue=201007.1 >>> + >>> + The DW_OP_regval_bits operation extracts a value from a register. */ >>> +DW_OP (DW_OP_INTEL_regval_bits, 0xfe) >> >> You're adding this to the GNU extensions space, which doesn't seem right, >> in particular given the name. > > What would be the correct way of adding an extension? It is, as far as I know, > only generated by the Intel Graphics Compilers, so we put INTEL in the name. > > Are you asking to rename it to GNU? Possibly. Not sure where the DW_OP_GNU_* namespace is maintained (and entries assigned), though. > Or are there separate extension spaces > per producer and we should declare it somewhere else? In principle the extensions are per "environment" aiui, which may or may not be "producer". Recently the DW_CFA_* handling was adjusted to cope with conflicting extensions. Likely the same is needed here. Especially if the value chosen is at risk of conflicting with something else down the road. Jan