From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8367 invoked by alias); 2 Aug 2016 09:47:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8332 invoked by uid 89); 2 Aug 2016 09:47:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:broadba, Hx-spam-relays-external:sk:broadba, H*RU:sk:broadba, email! X-HELO: mail-lf0-f50.google.com Received: from mail-lf0-f50.google.com (HELO mail-lf0-f50.google.com) (209.85.215.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 02 Aug 2016 09:47:02 +0000 Received: by mail-lf0-f50.google.com with SMTP id b199so134323763lfe.0 for ; Tue, 02 Aug 2016 02:47:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to; bh=WwQljigOfsz0qUsmVOD7E0qj3suuW5bPrWBEW9mDuW8=; b=R2R0EX10X1z+5kn0qBOVyQNsjawu3YotHZ3Eomx6WZnxyhXXVVWey/ARLgbqtCB/Lm J3ga1sdS4cKMrW6NBEtIr4a/zJV7eb/CZWtS37Sw6YQeRl96DSzFrQifl+TkhX6x4JFh pSwBPYQANTGcYnYW8P1ayc3VISyGujSW4DP2sW00B8dLZTOcmSIpFmqKJQeXSq+0HnP3 9XY7cNkrQupyArsgCKHOxcDRN+VyGMGX+JsiGD1VdHOVwPHVoSSNztPZakUZJtNHduwr tFOJmJT1q2g/yqX8jr7gq9swus12kGY3PWyVPXF5Oo9b3hPfTgTQ9L2w8l1TDWCUd/za 0vdw== X-Gm-Message-State: AEkooutpl97vXxNs0A/Xqic5d817rNyHrN4l/ctmoBmjmTacLTgn41KsZdFr8Yxn8dbm7Q== X-Received: by 10.25.43.204 with SMTP id r195mr10584616lfr.176.1470131218676; Tue, 02 Aug 2016 02:46:58 -0700 (PDT) Received: from [192.168.4.39] (broadband-95-84-200-6.nationalcablenetworks.ru. [95.84.200.6]) by smtp.gmail.com with ESMTPSA id i80sm334583lfg.6.2016.08.02.02.46.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Aug 2016 02:46:57 -0700 (PDT) Subject: Re: Program-assigned thread names on Windows From: LRN To: gdb-patches@sourceware.org References: <5052d495-ea40-b364-96ea-9e68c90bd747@gmail.com> <14995502.J10EtrK3xV@ralph.baldwin.cx> <6a3446f9-63dc-67a1-3702-203d77c8d85d@gmail.com> <0cabec98-8411-2c3a-98d0-3d950de02bc5@gmail.com> <28023f06-f99c-77d1-10cf-5243f2a082a4@gmail.com> <0e59216f-77cb-608a-aa39-578c2610eda1@dronecode.org.uk> <0f064b2b-6b51-f132-caa6-a4c1a85585a3@gmail.com> <2c9f43ec-af6f-cdaf-8e45-b251588b9b89@gmail.com> <0515957c-dfd2-b119-d423-517917e8a5cd@gmail.com> Message-ID: <40aaee01-35a5-9d3f-ceae-2bf4ca53a7b9@gmail.com> Date: Tue, 02 Aug 2016 09:47:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:50.0) Gecko/20100101 Thunderbird/50.0a1 MIME-Version: 1.0 In-Reply-To: <0515957c-dfd2-b119-d423-517917e8a5cd@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="SR1IHvdkcfXf5GD448hgnWGcqQu3P00cd" X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00025.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --SR1IHvdkcfXf5GD448hgnWGcqQu3P00cd Content-Type: multipart/mixed; boundary="vt3DNKH3xxT2VGMXoG4eDk2gtMAn8u0T8" From: LRN To: gdb-patches@sourceware.org Message-ID: <40aaee01-35a5-9d3f-ceae-2bf4ca53a7b9@gmail.com> Subject: Re: Program-assigned thread names on Windows References: <5052d495-ea40-b364-96ea-9e68c90bd747@gmail.com> <14995502.J10EtrK3xV@ralph.baldwin.cx> <6a3446f9-63dc-67a1-3702-203d77c8d85d@gmail.com> <0cabec98-8411-2c3a-98d0-3d950de02bc5@gmail.com> <28023f06-f99c-77d1-10cf-5243f2a082a4@gmail.com> <0e59216f-77cb-608a-aa39-578c2610eda1@dronecode.org.uk> <0f064b2b-6b51-f132-caa6-a4c1a85585a3@gmail.com> <2c9f43ec-af6f-cdaf-8e45-b251588b9b89@gmail.com> <0515957c-dfd2-b119-d423-517917e8a5cd@gmail.com> In-Reply-To: <0515957c-dfd2-b119-d423-517917e8a5cd@gmail.com> --vt3DNKH3xxT2VGMXoG4eDk2gtMAn8u0T8 Content-Type: multipart/mixed; boundary="------------196915EECC991366D8F3DAD4" Content-Language: en-US This is a multi-part message in MIME format. --------------196915EECC991366D8F3DAD4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1150 On 28.07.2016 10:21, LRN wrote: > On 28.07.2016 0:35, Jon Turney wrote: >> >> Doing a bit of testing with this patch... >> >> On 26/07/2016 18:15, LRN wrote: >>> + named_thread =3D find_thread_ptid (named_thread_ptid); >> >> ... it seems this may return NULL (e.g. if the thread we are naming was= =20 >> short-lived and has already exited, or if the thread id was invalid) ... >> >>> + >>> + thread_name =3D NULL; >>> + thread_name_len =3D target_read_string (thread_name_target, &thread= _name, 1025, 0); >>> + if (thread_name_len > 0 && thread_name !=3D NULL) >>> + { >>> + thread_name[thread_name_len - 1] =3D '\0'; >>> + if (thread_name[0] !=3D '\0') >>> + { >>> + xfree (named_thread->name); >> >> ... so this becomes a null dereference. >> >>> + named_thread->name =3D thread_name; >>> + } >>> + else >>> + { >>> + xfree (thread_name); >>> + } >> >=20 > True. >=20 > The simplest fix for this is to turn the check >> thread_name[0] !=3D '\0' > into >> thread_name[0] !=3D '\0' && named_thread !=3D NULL >=20 >=20 So, what happens now? --=20 O< ascii ribbon - stop html email! - www.asciiribbon.org --------------196915EECC991366D8F3DAD4 Content-Type: application/pgp-keys; name="0x6759BA74.asc" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0x6759BA74.asc" Content-length: 3718 -----BEGIN PGP PUBLIC KEY BLOCK-----=0A= Version: GnuPG v2=0A= =0A= mQINBFd+4e0BEACxh5wQhm5pG3DMdXokYTZYyncAc0MGQkuCG7+0CUa06VW+qVz3=0A= x+wkWRSJSbFrltSzNpKY67kOGPc1b7e1V4vIQ5ubNSYNOnwqFedEorBCyA6jvpfE=0A= vmLHcWJyK6emZC2s09ToxN1ovzcJBkQMgpJNYj4jZHdHEJ0PD+qEp7bKTXlxzWXM=0A= oHjPdykSLPDuTzQ1Gi09OakKhzOUvg+3Lgqo1aAf+r8HtysM19wUE06h1BYpsMo/=0A= gP87w/uhyqrqqAPBb3tpJtAhw8OcUREsJ4GC5zsp80eHy7IS6LIrPB3nf9XyIxvd=0A= 5qql9y1XclbB/sTGfD2Z27gYLLqFDIlYxXKT1z999yGN71gXYoLi9wbqpP0VSbdh=0A= tr8LVhGiuP+BPNq1y62wKyBKpJulBq2TnYWhukYowI1tCkCFeL1F0yG2M0RTvo3P=0A= dUp6YSHiNbuvgiFzoow2YVCPW+w2MBFR2S1Si72Yegq2+tf5Dd0mSOEKOhaChz/X=0A= L3gFlbjgaF0qA879Q/8pppjdsmwDY+q48WV4NnI3bPsTlZ6dKnI0ZMpct9Kfi7E5=0A= dmexGdOCde4RbEs4dOsdMhjFl9B1YQPjKpTmh7FtoTDJqMklZEAzBr+pEDb7BorM=0A= Beh2aHsJ0Z7Qd52BCaUAIuPUXjwXDI4qzf7UyWLFS66BkeDXBRDRWaRL5QARAQAB=0A= tBdMUk4gPGxybjE5ODZAZ21haWwuY29tPokCPwQTAQgAKQUCV37h7QIbIwUJCWYB=0A= gAcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEI2t6SdnWbp0qtoQAIjcnzeN=0A= riwftAfLsnXKYBrxmdbfPsmu4G7cQxsabst841sOrvWFPHTkEZk/xpfyQgxpZEiB=0A= 8uF82XKNbHNh9+nWqiDyt/Y9v23IIt1fIodOuB1q3Jdbh7nraflgzeji91rR3BuP=0A= mKcbpX+t4zlOg2RNh3dG+xoY91C5gXXWqBZ73kyGDHkpp2jGFXNStzdlcR4qLBiV=0A= dbtXfU/mnmB3tFuojx/zgL71816G2toBZzeWT/6c7UnmrubarvbNIVPbYufM0Xzw=0A= 7sK1y+i6p+QnZPZJ7nytINAVAZJ3pxle1Ajwb5p4QAVSsau78iG04/9cNU+gtftT=0A= kwNOIJ0LDnj+S6A58uLIr2Ebl4Jr4g0MPlw74CsUIspQz9sb6/yANLQ98kz3PrUa=0A= MpodI2dNpV8UROoJ/t96ys755FcEb/09SDJcTUx7QlPukgoq4mrWqB59kVID7CKq=0A= HRRDanuoyR/+ITDUxXUEUIJkWGYzUfKzjI8ditBCI6zxNftWCaiw5XkrEEpctvzS=0A= CBbNE7KjAoFbZDnsXHgg9xZWpAzYYP6aCmBvpjISMGihXbw1oS6mJvvHTFSzjTvX=0A= QHShvyO8XLI7Q+NwrYV+mVNvtBX+mQaTsQdS9knSpoHHO/N0QlCUzbnPIEOVKjN6=0A= Hw7bcBokYeI0ez3yMZlf/bU/yyMRfxskOqxciQEcBBMBCAAGBQJXfuIzAAoJEOs4=0A= Jb6SI2CwxPgIAJtQBb/79MSdZZb3kggOC0ClZ7WDRSdP31R272gdckcbqVqm7vMl=0A= 0OZxQH5G4QRuFNLMSJG5ytf//qoxYj5CmvQS5NkP/sgnMaHvjHG+jRaBfB9t00Um=0A= h24BBL04Ac0lv3eiBc64nUJT37dEBUNEE8fgQ67gnV1hacqybVXqWIm1RXluL+Un=0A= fdFsbD6KWHLY2uPrARXdLYT7veUPnEgziw4s/2AVrGHiSgNZV1Z8pFMsuiUGpCRr=0A= 1K0r8b6hP3nxa0xxzk83NrKI6ZL1Jyhlqe7dLSWaSVofHk9WmcARZ+hJ/PlP+9N5=0A= Fd5ZuJ9R5t8C0gUB5v1ID4vPxt/YFCeiVJy5Ag0EV37h7QEQAKcbtHNm2vc6aYgR=0A= /eK0cJmJOqV3S0PtXychIV6zYj2/DppUOttsQN39nEgTBui1QFYfVgYNv3S0DBZY=0A= ESSijTLrzyCbzYL9AL/OzIgo++m8F0lERhhMKsVKtdZWLBflkQgPgCpMdwqhGdRP=0A= 5WrximbRtHN7JD4TCfupCqepefqvxyYv/pHYcDTFEycEChkRgCpc88tTxNdAyd2+=0A= F7lfvMxsgGmNcMa5IzIm1GXjKQONyiMffmjYT0Sod/AS/RA7z3aTv9/2Sm4TLgae=0A= 4BtV+ZU39VMkfA8c2DsnVi4zVKOBho7MH/Lwar2bQwKZ8U1TKhKDwK0Q1eYTq+3U=0A= Nc6Rk/9QolYpYup7/lH5wWppPvipqlltTQa6F0csD6AIc9W7rO7RVFo+lqvrEZAw=0A= AUXrRCTFtBijg715eZenDzS0QZw9WtQ6ufhsAamap6hJQmIZD3HdWdrHCT1TQ/Tt=0A= JzPAyIYbRbKCe2hoxUojF0A/P1ZL90kf/OZPQ6Oisl5XMyuyiJFgVbdbXYMJ+f+k=0A= 3pTrVxB9vASmGxX3LXCxVJAZ9xJWdBC73VK7rwit0tA8ijekrmkhSjZlIZCKvDYA=0A= j9fV4O6QXRuuFZKo4xGYWCIPFwe802jOrbvQw8YT5CgN7hGMUyHV/GCH50uUoVJD=0A= andFGy7hvTckfXk85oXARMswdyQ3ABEBAAGJAiUEGAEIAA8FAld+4e0CGwwFCQlm=0A= AYAACgkQja3pJ2dZunQeVQ/9FtseE5WqnmvPGc5NPGvbWhrd5x9CpStPG9b+xsBu=0A= 91ZXrMHsNOVQ0SxFdB708OT15sTy1ldeemxUK62E5XO1bvFJ4R1gHkWe6K/j9TfG=0A= Fshbyl3J6WKwG2qwT2JpNVpb+6QShFZVRe9a1rn3D/DNZurj3XYgVQGWlYVYT/LA=0A= 32zmBjQEzSXMbDBR/wSiJzYqgTB+9udGkcrYVgrmNz5YSA2mp6l1+PH/i++FD4j/=0A= KWFVnmqt1QqT8Q0l4MYQH65MdzHdspwfMt0XZ5abnubWIO78ImbOA/CD7MwbuWvy=0A= zezkiDcqQQ2G8mu/ER3oByfQ84iMIxGv1V608EBddHWygd6YQIKdScay0D+54IUz=0A= DXyv9tcnAAnxvMM5wzJyjWytOwL2H7FvSVAtfdywaF2wZA0iHho5Df8OeZdPEZhF=0A= 85GngH3hOBE0EAUMSFwThhRU7a2oMLSTFXRg0bKC3n0MoNExAV/oKiSM5HC06PsP=0A= exONpT/8WHL6GRk6vfsj09m7qScZSvyX35TxggnEHNwNW5/aYKIuhsXohxhLkUqM=0A= Bzu9/Xdq0xPOTyJSTberO8LR1TdWwi2WtPEBOtD25VMtEwhHrX3BKBkmYVu5f7vr=0A= CZikOLr7N8a5zJHJIiEdA2uljajBVTkPRCbMVsIBN2VVPcY2YOyNmG4gAtYmuDRL=0A= rb8=3D=0A= =3D8FDv=0A= -----END PGP PUBLIC KEY BLOCK-----=0A= --------------196915EECC991366D8F3DAD4-- --vt3DNKH3xxT2VGMXoG4eDk2gtMAn8u0T8-- --SR1IHvdkcfXf5GD448hgnWGcqQu3P00cd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXoGwKAAoJEI2t6SdnWbp0cs8P/2pk7n67k4Wgc6S8Q1YLrj57 6mIbmJqtEGZPk4MkGNoPakhOTHUEbhgGuDLU5whIbCkFPKYWZxleSm0npJsOFxWL 4wi5lT2OAgQlv+6gciSJG15OQbMuvZ5I7xTWdsrUMU+JV5NINUAbYIJIMlMQEL4R h/qUj8yZvnOAIVN/MpafouxP1AZmpNAVNN1rfXnn8XtP4ORf4iFQkcmPa7In1sgF g6yzdeISZaOOrtZqzgIEUO4G/af3fmfwI5wKUhsbvBNKP9waLEMjyKLeBb1kjcix rAmsKJxSohzuAEM8sjqd1CjOz/c84euSReyX3BxeATTJU/uytK/n1TEZLkD8Oxgl O6KeewyrmYedFV/yKpgELYsnlbaU9oQrCt+Tu1QxuJdlV7vHX19/kusMu7lKOE0T rmjscM9Vn6uWpoIhGXU0VQBjDCWLW+zi4/jG1rOG98Uiw7/13gv/AIU+szC9z/5u FJvnqKaIhF6yfK2VlCx7MWQF7Fo4PxYfPcu6WBWz8aFJbRnoswvNrG6648tgcV8N 7aEE4tBntHH9ZKNxma01ilftuaCS2byQ+7DYimAPikLcPaQF2t3SLXjUhAJQLlCI z+F0erBNBYDXbZjR748gJg/TDJY5Ht6ra2vxQ8EcHGyUgJ6eBDD/H4WKfiuLyEBY nDG+23/eVX3dfWDchL6O =Zni6 -----END PGP SIGNATURE----- --SR1IHvdkcfXf5GD448hgnWGcqQu3P00cd--