From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2284 invoked by alias); 16 Jul 2004 21:31:42 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2265 invoked from network); 16 Jul 2004 21:31:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 16 Jul 2004 21:31:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6GLVge3007226 for ; Fri, 16 Jul 2004 17:31:42 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6GLVea00949; Fri, 16 Jul 2004 17:31:41 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id E76C72B9D; Fri, 16 Jul 2004 17:31:38 -0400 (EDT) Message-ID: <40F8493A.6050003@gnu.org> Date: Fri, 16 Jul 2004 21:31:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Kei Sakamoto Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/m32r] Fix breakpoint bug of m32rsdi protocol; remote-m32r-sdi.c re-indented. References: <020801c463e4$6c92a660$5169910a@E5A02646> <021701c463e4$ab8749c0$5169910a@E5A02646> In-Reply-To: <021701c463e4$ab8749c0$5169910a@E5A02646> Content-Type: multipart/mixed; boundary="------------080906030601020506070003" X-SW-Source: 2004-07/txt/msg00205.txt.bz2 This is a multi-part message in MIME format. --------------080906030601020506070003 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-length: 1626 Kei, It looks like some re-indentation got mixed in with the change proper vis: - if (!sdi_desc) + if (!sdi_desc) - if (c != '+') /* error */ + if (c != '+') /* error */ ... I've committed the attached which re-indents remote-m32r-sdi.c using gdb/gdb_indent.sh. You'll want to merge in that change and strip out any other stray mods. Looking at the change proper, given the many occurances of sequences like this: + buf[0] = SDI_WRITE_MEMORY; + store_long_parameter (buf + 1, 0xffff8080 + 4 * i); + store_long_parameter (buf + 5, 4); + store_unsigned_integer (buf + 9, 4, bp_addr); + send_data (buf, 13); + buf[0] = SDI_WRITE_MEMORY; + store_long_parameter (buf + 1, 0xffff8200 + 4 * i); + store_long_parameter (buf + 5, 4); + store_long_parameter (buf + 9, 0xffffffff); + send_data (buf, 13); + buf[0] = SDI_WRITE_MEMORY; + store_long_parameter (buf + 1, bp_addr); + store_long_parameter (buf + 5, 4); + if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG) + { + buf[9] = dbt_bp_entry[0]; + buf[10] = dbt_bp_entry[1]; + buf[11] = dbt_bp_entry[2]; + buf[12] = dbt_bp_entry[3]; + } + else + { + buf[9] = dbt_bp_entry[3]; + buf[10] = dbt_bp_entry[2]; + buf[11] = dbt_bp_entry[1]; + buf[12] = dbt_bp_entry[0]; can you add helper functions like: send_l4_data (SDI_WRITE_MEMORY, 0xffff8200 + 4 * i, 4, 0xffffffff); for each of these cases (and any others you feel useful). Andrew --------------080906030601020506070003 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="diffs" Content-length: 3018 MjAwNC0wNy0xNiAgQW5kcmV3IENhZ25leSAgPGNhZ25leUBnbnUub3JnPgoK CSogcmVtb3RlLW0zMnItc2RpLmM6IFJlLWluZGVudC4KCkluZGV4OiByZW1v dGUtbTMyci1zZGkuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3NyYy9zcmMvZ2RiL3JlbW90ZS1tMzJyLXNkaS5jLHYKcmV0cmll dmluZyByZXZpc2lvbiAxLjQKZGlmZiAtcCAtdSAtcjEuNCByZW1vdGUtbTMy ci1zZGkuYwotLS0gcmVtb3RlLW0zMnItc2RpLmMJMTUgSnVuIDIwMDQgMDE6 MDQ6MTkgLTAwMDAJMS40CisrKyByZW1vdGUtbTMyci1zZGkuYwkxNiBKdWwg MjAwNCAyMToxNTo1MSAtMDAwMApAQCAtMTYxLDcgKzE2MSw3IEBAIGdldF9h Y2sgKHZvaWQpCiB7CiAgIGludCBjOwogCi0gIGlmICghc2RpX2Rlc2MpIAor ICBpZiAoIXNkaV9kZXNjKQogICAgIHJldHVybiAtMTsKIAogICBjID0gc2Vy aWFsX3JlYWRjaGFyIChzZGlfZGVzYywgU0RJX1RJTUVPVVQpOwpAQCAtMTY5 LDcgKzE2OSw3IEBAIGdldF9hY2sgKHZvaWQpCiAgIGlmIChjIDwgMCkKICAg ICByZXR1cm4gLTE7CiAKLSAgaWYgKGMgIT0gJysnKQkJLyogZXJyb3IgKi8K KyAgaWYgKGMgIT0gJysnKQkJCS8qIGVycm9yICovCiAgICAgcmV0dXJuIC0x OwogCiAgIHJldHVybiAwOwpAQCAtMTgxLDcgKzE4MSw3IEBAIHNlbmRfZGF0 YSAodm9pZCAqYnVmLCBpbnQgbGVuKQogewogICBpbnQgcmV0OwogCi0gIGlm ICghc2RpX2Rlc2MpIAorICBpZiAoIXNkaV9kZXNjKQogICAgIHJldHVybiAt MTsKIAogICBpZiAoc2VyaWFsX3dyaXRlIChzZGlfZGVzYywgYnVmLCBsZW4p ICE9IDApCkBAIC0yMDAsNyArMjAwLDcgQEAgcmVjdl9kYXRhICh2b2lkICpi dWYsIGludCBsZW4pCiAgIGludCB0b3RhbCA9IDA7CiAgIGludCBjOwogCi0g IGlmICghc2RpX2Rlc2MpIAorICBpZiAoIXNkaV9kZXNjKQogICAgIHJldHVy biAtMTsKIAogICB3aGlsZSAodG90YWwgPCBsZW4pCkBAIC0yNjQsOCArMjY0 LDcgQEAgY2hlY2tfbW11X3N0YXR1cyAodm9pZCkKIC8qIFRoaXMgaXMgY2Fs bGVkIG5vdCBvbmx5IHdoZW4gd2UgZmlyc3QgYXR0YWNoLCBidXQgYWxzbyB3 aGVuIHRoZQogICAgdXNlciB0eXBlcyAicnVuIiBhZnRlciBoYXZpbmcgYXR0 YWNoZWQuICAqLwogc3RhdGljIHZvaWQKLW0zMnJfY3JlYXRlX2luZmVyaW9y IChjaGFyICpleGVjZmlsZSwgY2hhciAqYXJncywgY2hhciAqKmVudiwKLQkJ ICAgICAgaW50IGZyb21fdHR5KQorbTMycl9jcmVhdGVfaW5mZXJpb3IgKGNo YXIgKmV4ZWNmaWxlLCBjaGFyICphcmdzLCBjaGFyICoqZW52LCBpbnQgZnJv bV90dHkpCiB7CiAgIENPUkVfQUREUiBlbnRyeV9wdDsKIApAQCAtMzI2LDcg KzMyNSw3IEBAIG0zMnJfb3BlbiAoY2hhciAqYXJncywgaW50IGZyb21fdHR5 KQogICAgIHsKICAgICAgIHBvcnRfc3RyID0gc3RyY2hyIChhcmdzLCAnOicp OwogICAgICAgaWYgKHBvcnRfc3RyID09IE5VTEwpCi0gICAgICAgIHNwcmlu dGYgKGhvc3RuYW1lLCAiJXM6JWQiLCBhcmdzLCBTRElQT1JUKTsKKwlzcHJp bnRmIChob3N0bmFtZSwgIiVzOiVkIiwgYXJncywgU0RJUE9SVCk7CiAgICAg ICBlbHNlCiAJc3RyY3B5IChob3N0bmFtZSwgYXJncyk7CiAgICAgfQpAQCAt NzA1LDcgKzcwNCw3IEBAIG0zMnJfd2FpdCAocHRpZF90IHB0aWQsIHN0cnVj dCB0YXJnZXRfd2EKICAgICAgIGlmIChjIDwgMCkKIAllcnJvciAoIlJlbW90 ZSBjb25uZWN0aW9uIGNsb3NlZCIpOwogCi0gICAgICBpZiAoYyA9PSAnLScp CS8qIGVycm9yICovCisgICAgICBpZiAoYyA9PSAnLScpCQkvKiBlcnJvciAq LwogCXsKIAkgIHN0YXR1cy0+a2luZCA9IFRBUkdFVF9XQUlUS0lORF9TVE9Q UEVEOwogCSAgc3RhdHVzLT52YWx1ZS5zaWcgPSBUQVJHRVRfU0lHTkFMX0hV UDsKQEAgLTE1NDAsMTEgKzE1MzksMTEgQEAgc2Rpc3RhdHVzX2NvbW1hbmQg KGNoYXIgKmFyZ3MsIGludCBmcm9tXwogICAgIHsKICAgICAgIGMgPSBzZXJp YWxfcmVhZGNoYXIgKHNkaV9kZXNjLCBTRElfVElNRU9VVCk7CiAgICAgICBp ZiAoYyA8IDApCi0gICAgICAgIHJldHVybjsKKwlyZXR1cm47CiAgICAgICBi dWZbaV0gPSBjOwogICAgICAgaWYgKGMgPT0gMCkKLSAgICAgICAgYnJlYWs7 Ci0gICAgfSAgICAKKwlicmVhazsKKyAgICB9CiAKICAgcHJpbnRmX2ZpbHRl cmVkICgiJXMiLCBidWYpOwogfQo= --------------080906030601020506070003--