From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26071 invoked by alias); 14 Jul 2004 19:15:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26062 invoked from network); 14 Jul 2004 19:15:29 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 14 Jul 2004 19:15:29 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i6EJFTe3027378 for ; Wed, 14 Jul 2004 15:15:29 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i6EJFR028680; Wed, 14 Jul 2004 15:15:28 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 3B07C2B9D; Wed, 14 Jul 2004 15:15:15 -0400 (EDT) Message-ID: <40F58643.3000102@gnu.org> Date: Wed, 14 Jul 2004 19:15:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfc] Revamp logical.exp References: <20040714182014.4F59C4B104@berman.michael-chastain.com> In-Reply-To: <20040714182014.4F59C4B104@berman.michael-chastain.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00167.txt.bz2 > The basic idea and the implementation are good. > > I hand-checked all the data in the tables for correctness. > It all looks fine to me. > > In the test name, could you include something grep'able. > So that if someone gets: > > FAIL: logical.exp: evaluation of x == y, {x = 1, y = 0} > > They can find the right gdb_test by grepping on the wordage > ("evalation of"). > > Yes, I see that there are only two gdb_test's in the whole file, > but I like the test names to have searchable parts. This has > been essential to me when finding things in structs.exp. > > Also please consider adding $val into the test name: > > FAIL: logical.exp: evaluation of x == y; {x = 1, y = 0}; expected 0 Like: variables x=1,y=0; initialize variables x=1,y=0; evaluate x == y; expecting 0 It reflects how the loop is implemented. However, I could change the test to something like: gdb_test "print x=1,y=0,x == y" " = 0" "evaluate x = y; variables x=1,y=0; expecting 0" If you want spaces, I'll need to tweak the tables. > I think that makes it easier to see whether the test is written > correctly or not, especially when someone goes to add 50 new tests. > > And, as always ... did you run it somewhere? My favorite, amd64 GNU/Linux. > 2004-07-14 Andrew Cagney > > * gdb.base/logical.exp: Update copyright. > (evaluate): New procedure. Use to re-implement tests using > several tables. Andrew