From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9601 invoked by alias); 8 Jul 2004 18:20:23 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9573 invoked from network); 8 Jul 2004 18:20:21 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 8 Jul 2004 18:20:21 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i68IKLe1019496 for ; Thu, 8 Jul 2004 14:20:21 -0400 Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i68IKJ016536; Thu, 8 Jul 2004 14:20:19 -0400 Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9]) by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i68IK8vU005518; Thu, 8 Jul 2004 14:20:17 -0400 Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72]) by touchme.toronto.redhat.com (Postfix) with ESMTP id 9D40A8001D0; Thu, 8 Jul 2004 14:20:08 -0400 (EDT) Message-ID: <40ED9058.7050100@redhat.com> Date: Thu, 08 Jul 2004 18:20:00 -0000 From: Jeff Johnston User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1 MIME-Version: 1.0 To: Jeff Johnston Cc: Michael Elizabeth Chastain , cagney@gnu.org, gdb-patches@sources.redhat.com Subject: Re: [RFA]: Fix jmain.exp to xfail for break at main References: <20040708034234.5BDA64B104@berman.michael-chastain.com> <40ED6991.7080505@redhat.com> In-Reply-To: <40ED6991.7080505@redhat.com> Content-Type: multipart/mixed; boundary="------------000805000701000707020104" X-SW-Source: 2004-07/txt/msg00077.txt.bz2 This is a multi-part message in MIME format. --------------000805000701000707020104 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 2315 Jeff Johnston wrote: > Michael Elizabeth Chastain wrote: > >> jj> Currently, the gdb.java/jmain.exp test has hard-coded line 6 as the >> jj> expected line number for a break at jmain.main (java.lang.String[]). >> jj> This occurs for gcc 3.3 and is incorrect. Line 6 is the end brace >> for >> jj> the main routine. As of gcc 3.4, the line number is reported to >> be line >> jj> 4. This also isn't what gdb wants as this points to the open brace. >> jj> The desired result is that we point to line 5 which is the first >> line in >> jj> main (return statement). That said, I have changed the expected >> line to >> jj> be 5 and set the test as an XFAIL. >> >> Dunno what Andrew will say about this patch but I don't think it's good. >> > > I did talk to Andrew briefly about this. > >> XFAIL means 'external fail'. If you add an XFAIL to the test suite, I >> want to see more analysis about what the bug is -- the best thing is an >> actual gcc PR number. In the gcc PR is a copy of jmain.java and the >> assembly language output and an explanation of why the assembly language >> output is incorrect. >> >> What does gcc HEAD do? >> > > It gives line 4. I meant to imply that above when I said "since 3.4", > but I'll clarify it here. For a similar C test case, it points to the > return statement. It definitely should not be line 6 in any circumstance. > >> If gcc HEAD actually gives line 5, then I would do this in the test >> script: >> >> # gcc HEAD 2004-07-05 marks the first line as 5, which is correct. >> # gcc 3.3.4 -gdwarf-2 marks the first line as line 6. >> # gcc 3.4.1 -gdwarf-2 marks the first line as line 4. >> set bpmain "Breakpoint .* file .*jmain.java, line 5\." >> >> If gcc HEAD gives some other line, then I think you need to file >> a PR against gcc. It may be low priority and not fixed for years, >> in which case you can XFAIL the test with that PR number. >> > > Ok, I will create the PR and resubmit the patch. > See attached patch. Ok to commit? >> Michael C >> >> === >> >> 2004-07-07 Jeff Johnston >> >> * gdb.java/jmain.exp: Fix expected line number for main to >> break at. Set XFAIL for break at main test since gcj does not >> provide line number info for first statement in main. >> > > --------------000805000701000707020104 Content-Type: text/plain; name="jmain-test.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="jmain-test.patch" Content-length: 809 Index: gdb.java/jmain.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.java/jmain.exp,v retrieving revision 1.1 diff -u -p -r1.1 jmain.exp --- gdb.java/jmain.exp 27 Jun 2004 00:41:39 -0000 1.1 +++ gdb.java/jmain.exp 8 Jul 2004 18:16:45 -0000 @@ -48,7 +48,7 @@ gdb_test "set print sevenbit-strings" ". # Where the breakpoint should always land -set bpmain "Breakpoint .* file .*jmain.java, line 6\." +set bpmain "Breakpoint .* file .*jmain.java, line 5\." gdb_load "${binfile}" setup_kfail *-*-* java/1567 @@ -63,4 +63,5 @@ gdb_test "break jmain.main" "${bpmain}" # Check that a fully qualified "main" works. gdb_load "${binfile}" +setup_xfail *-*-* gcc/16439 gdb_test "break \'${testfile}.main(java.lang.String\[\])\'" "${bpmain}" --------------000805000701000707020104--