From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23047 invoked by alias); 6 Jul 2004 15:18:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23039 invoked from network); 6 Jul 2004 15:18:53 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 6 Jul 2004 15:18:53 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i66FIre3012740 for ; Tue, 6 Jul 2004 11:18:53 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i66FIq009067; Tue, 6 Jul 2004 11:18:52 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 9A7CD2B9D; Tue, 6 Jul 2004 11:18:41 -0400 (EDT) Message-ID: <40EAC2D1.3060708@gnu.org> Date: Tue, 06 Jul 2004 15:18:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Jim Blandy Cc: gdb-patches@sources.redhat.com Subject: Re: RFA: make sim interface use gdbarch methods for collect/supply References: <40E57CDF.8090809@gnu.org> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00041.txt.bz2 > Andrew Cagney writes: > >>>> > At the moment, remote-sim.c's gdbsim_fetch_register and >>>> > gdbsim_store_register functions assume that the simulator's register >>>> > set (as visible via sim_fetch_register and sim_store_register) >>>> > corresponds exactly to GDB's raw register set. This patch is meant to >>>> > remove that assumption. >> >>> >>> Why do we need this extra level of indirection? Since gdb/sim are >>> paired at the source code level, we can simply change the gdb/sim >>> interface. > > > You mean (in this case) just go in and tweak sim/ppc/sim_calls.c so > that the sim's register set (as viewed by sim_fetch_register and > sim_store_register) does match GDB's raw regcache? Yes, it lets us avoid an extra level of indirection and all the complexity it brings. Lets do that, no point in adding a new interfaces when we can solve the problem by adjusting the old. Andrew