From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-34004-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 4633 invoked by alias); 22 Jun 2004 19:47:16 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 4623 invoked from network); 22 Jun 2004 19:47:16 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 22 Jun 2004 19:47:16 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5MJlGe1017489
	for <gdb-patches@sources.redhat.com>; Tue, 22 Jun 2004 15:47:16 -0400
Received: from pobox.toronto.redhat.com (pobox.toronto.redhat.com [172.16.14.4])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5MJlF015780;
	Tue, 22 Jun 2004 15:47:15 -0400
Received: from touchme.toronto.redhat.com (IDENT:postfix@touchme.toronto.redhat.com [172.16.14.9])
	by pobox.toronto.redhat.com (8.12.8/8.12.8) with ESMTP id i5MJlFtn016514;
	Tue, 22 Jun 2004 15:47:15 -0400
Received: from redhat.com (toocool.toronto.redhat.com [172.16.14.72])
	by touchme.toronto.redhat.com (Postfix) with ESMTP
	id 99A268003AD; Tue, 22 Jun 2004 15:47:13 -0400 (EDT)
Message-ID: <40D88CC1.4080905@redhat.com>
Date: Tue, 22 Jun 2004 19:47:00 -0000
From: Jeff Johnston <jjohnstn@redhat.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 Netscape/7.1
MIME-Version: 1.0
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sources.redhat.com, uweigand@de.ibm.com
Subject: Re: [RFA]: Fix for watchpoint regressions
References: <40D7016F.1070406@redhat.com> <2719-Mon21Jun2004220328+0300-eliz@gnu.org> <40D73DC0.5090601@redhat.com> <9743-Tue22Jun2004072010+0300-eliz@gnu.org>
In-Reply-To: <9743-Tue22Jun2004072010+0300-eliz@gnu.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-06/txt/msg00496.txt.bz2

Eli Zaretskii wrote:
>>Date: Mon, 21 Jun 2004 15:57:52 -0400
>>From: Jeff Johnston <jjohnstn@redhat.com>
>>
>>>>2004-06-18  Jeff Johnston  <jjohnstn@redhat.com>
>>>>
>>>>        * infrun.c (handle_inferior_event): Initialize stopped_by_watchpoint
>>>>        to -1.
>>>>        * breakpoint.c (bpstat_stop_status): Move check for ignoring
>>>>        untriggered watchpoints to a separate if clause.  Update function
>>>>        comment regarding STOPPED_BY_WATCHPOINT argument.
>>>
>>>
>>>Won't this break the cases that caused the addition of testing that
>>>stopped_by_watchpoint is non-zero in bpstat_stop_status?
>>>
>>
>>I took care to try to ensure that the problem the original patch was fixing was 
>>still being addressed.
> 
> 
> Thanks for taking time to explain the situation and the fix.
>

No problem. :)

> Your patch is approved.
> 

Thanks.  Patch applied.

-- Jeff J.