From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-33998-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 32377 invoked by alias); 21 Jun 2004 23:55:19 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 32359 invoked from network); 21 Jun 2004 23:55:18 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 21 Jun 2004 23:55:18 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5LNtHe3011858
	for <gdb-patches@sources.redhat.com>; Mon, 21 Jun 2004 19:55:18 -0400
Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5LNtH026791;
	Mon, 21 Jun 2004 19:55:17 -0400
Received: from gnu.org (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 91A7B2B9D; Mon, 21 Jun 2004 19:55:05 -0400 (EDT)
Message-ID: <40D77559.5020506@gnu.org>
Date: Mon, 21 Jun 2004 23:55:00 -0000
From: Andrew Cagney <cagney@gnu.org>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217
MIME-Version: 1.0
To: "Martin M. Hunt" <hunt@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] change mips SP_REGNUM to cooked register
References: <1087849304.5508.4.camel@hunt.cipe.redhat.com>
In-Reply-To: <1087849304.5508.4.camel@hunt.cipe.redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-06/txt/msg00490.txt.bz2

> This patch is part of the Mips CFI work started by Kevin Buettner.
> As requested, I am splitting the previously posted patch into multiple
> small patches.
> 
> To get DWARF2 CFI unwinding to work, SP_REGNUM needs to refer to the
> cooked register number, not the raw register number.
> 
> 2004-06-21  Martin Hunt  <hunt@redhat.com>
> 	Kevin Buettner <kevinb@redhat.com>
> 
>         * config/mips/tm-mips.h (SP_REGNUM): Delete define.
> 	* mips-tdep.h (MIPS_SP_REGNUM): Define.
> 	* mips-tdep.c (mips_gdbarch_init): Set SP_REGNUM via call
> 	to set_gdbarch_sp_regnum().  Use cooked register number.
>         (SP_REGNUM): Replace all occurrences with MIPS_SP_REGNUM.

Yes, definitly ok.

Andrew