From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32011 invoked by alias); 18 Jun 2004 17:21:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31921 invoked from network); 18 Jun 2004 17:21:41 -0000 Received: from unknown (HELO moutng.kundenserver.de) (212.227.126.176) by sourceware.org with SMTP; 18 Jun 2004 17:21:41 -0000 Received: from [212.227.126.207] (helo=mrelayng.kundenserver.de) by moutng.kundenserver.de with esmtp (Exim 3.35 #1) id 1BbN3d-0004By-00; Fri, 18 Jun 2004 19:21:41 +0200 Received: from [217.235.217.168] (helo=[217.235.217.168]) by mrelayng.kundenserver.de with asmtp (Exim 3.35 #1) id 1BbN3c-0007eK-00; Fri, 18 Jun 2004 19:21:40 +0200 Message-ID: <40D32489.9070503@kay-mueller.de> Date: Fri, 18 Jun 2004 17:21:00 -0000 From: Michael Mueller User-Agent: Mozilla/5.0 MIME-Version: 1.0 To: gdb-patches@sources.redhat.com, binutils@sources.redhat.com Subject: [RFC]: patch #2 for Sun C compiled target programs Content-Type: multipart/mixed; boundary="------------030803050000090607050404" X-Provags-ID: kundenserver.de abuse@kundenserver.de auth:acfe4e233830c7fd36d26ada4c2bf87e X-SW-Source: 2004-06/txt/msg00433.txt.bz2 This is a multi-part message in MIME format. --------------030803050000090607050404 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 3469 For Sun C compiled 64 bit target programs "print localvar" does not work (PR gdb/1669). I verified this against these compiler versions: Sun C 5.5 2003/03/12 Forte Developer 7 C 5.4 2002/03/09 Sun WorkShop 6 update 2 C 5.3 2001/05/15 Sun WorkShop 6 2000/04/07 C 5.1 This is what happens: GNU gdb 2004-06-17-cvs Copyright 2004 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "sparc-sun-solaris2.8"... (gdb) b main Breakpoint 1 at 0x100000894: file p2.c, line 6. (gdb) run Starting program: /export/home/michaelm/gdb/gdb-6.1.patch/tst/p2 Breakpoint 1, main () at p2.c:6 6 int n = 7; (gdb) p n Cannot access memory at address 0x7ffff009 There are 2 different problems that need to be fixed. One might involve binutils. *** Problem 1 ************************************************* In dbxread.c function read_ofile_symtab macro INTERNALIZE_SYMBOL (nlist, bufp, abfd) is called to set nlist.n_value (type bfd_vma = unsigned long, size 64 bit) to the negative offset of a local variable inside the stack frame. This offset is taken from bufp->e_value which is 4 bytes (bfd_byte e_value[4]). This is the macro definition: #define INTERNALIZE_SYMBOL(intern, extern, abfd) \ { \ (intern).n_type = bfd_h_get_8 (abfd, (extern)->e_type); \ (intern).n_strx = bfd_h_get_32 (abfd, (extern)->e_strx); \ (intern).n_desc = bfd_h_get_16 (abfd, (extern)->e_desc); \ if (bfd_get_sign_extend_vma (abfd)) \ (intern).n_value = bfd_h_get_signed_32 (abfd, (extern)->e_value);\ else \ (intern).n_value = bfd_h_get_32 (abfd, (extern)->e_value); \ } The problem is that bfd_get_sign_extend_vma returns 0 and the negative value is not sign extended and turns into a large positive number. There was a similar problem in the past for mips 64 bit: The problem with stabs and sign extension http://sources.redhat.com/ml/gdb/2001-08/msg00078.html db/ChangeLog-2001: 2001-08-14 H.J. Lu (hjl@gnu.org) It was fixed by introducing the call to bfd_get_sign_extend_vma into the macro. Following this example one could fix this by changing binutils to make bfd_get_sign_extend_vma return 1 for sparc solaris 64 bit. Function bfd_get_sign_extend_vma is also called in dwarf2read.c and I don't know what the effects of such a change would be there. I'm also not sure if this it the intended use of bfd_get_sign_extend_vma. As a temporary workaround I changed INTERNALIZE_SYMBOL to always call bfd_h_get_signed_32 (see the appended dbxread.workaround). *** Problem 2 ************************************************* Function sparc64_frame_base_address in sparc64-tdep.c needs to be fixed: /* ??? Should we take BIAS into account here? */ return cache->base; The answer to the question in comment is yes, see the appended patch. 2004-05-18 Michael Mueller * sparc64-tdep.c: fix PR gdb/1669, printing of 64 bit local variables --------------030803050000090607050404 Content-Type: text/plain; name="sparc64-tdep.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="sparc64-tdep.patch" Content-length: 796 Index: sparc64-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/sparc64-tdep.c,v retrieving revision 1.12 diff -c -p -r1.12 sparc64-tdep.c *** sparc64-tdep.c 7 Jun 2004 02:02:55 -0000 1.12 --- sparc64-tdep.c 18 Jun 2004 12:41:26 -0000 *************** sparc64_frame_base_address (struct frame *** 568,575 **** struct sparc_frame_cache *cache = sparc64_frame_cache (next_frame, this_cache); ! /* ??? Should we take BIAS into account here? */ ! return cache->base; } static const struct frame_base sparc64_frame_base = --- 568,574 ---- struct sparc_frame_cache *cache = sparc64_frame_cache (next_frame, this_cache); ! return cache->base + BIAS; } static const struct frame_base sparc64_frame_base = --------------030803050000090607050404 Content-Type: text/plain; name="dbxread.workaround" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="dbxread.workaround" Content-length: 837 ###### This is a WORKAROUND, not a proper patch: ####### *** dbxread.c.orig Fri Jun 18 14:56:56 2004 --- dbxread.c Fri Jun 18 14:56:55 2004 *************** stabs_seek (int sym_offset) *** 852,861 **** --- 852,865 ---- (intern).n_type = bfd_h_get_8 (abfd, (extern)->e_type); \ (intern).n_strx = bfd_h_get_32 (abfd, (extern)->e_strx); \ (intern).n_desc = bfd_h_get_16 (abfd, (extern)->e_desc); \ + /*** workaround for Solaris sparc 64 \ if (bfd_get_sign_extend_vma (abfd)) \ + ***/ \ (intern).n_value = bfd_h_get_signed_32 (abfd, (extern)->e_value); \ + /*** workaround for Solaris sparc 64 \ else \ (intern).n_value = bfd_h_get_32 (abfd, (extern)->e_value); \ + ***/ \ } /* Invariant: The symbol pointed to by symbuf_idx is the first one --------------030803050000090607050404--