From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31901 invoked by alias); 11 Jun 2004 17:32:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31878 invoked from network); 11 Jun 2004 17:32:51 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 11 Jun 2004 17:32:51 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5BHWpi7009111 for ; Fri, 11 Jun 2004 13:32:51 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5BHWo020345; Fri, 11 Jun 2004 13:32:50 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0EE972B9D; Fri, 11 Jun 2004 13:32:43 -0400 (EDT) Message-ID: <40C9ECBA.1060108@gnu.org> Date: Fri, 11 Jun 2004 17:32:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Andrew Cagney , Mark Kettenis Cc: drow@false.org, gdb-patches@sources.redhat.com, roland@redhat.com Subject: Re: Revamp sniffer; Was: [obish?sym;rfa:doc] Wire up vsyscall References: <409A8C2A.2010605@gnu.org> <409AA61F.8050807@gnu.org> <20040507012549.GA30182@nevyn.them.org> <409FF3D7.5000106@gnu.org> <200405102140.i4ALe13A001092@elgar.kettenis.dyndns.org> <20040511145344.GA15501@nevyn.them.org> <40A0FFB1.8030407@gnu.org> <20040511172619.GA19487@nevyn.them.org> <40A16FA1.9060506@gnu.org> <200405152057.i4FKvdt2000817@elgar.kettenis.dyndns.org> <40A8F308.9040900@gnu.org> <40B3CEC0.2070405@gnu.org> In-Reply-To: <40B3CEC0.2070405@gnu.org> Content-Type: multipart/mixed; boundary="------------050801060306050203080102" X-SW-Source: 2004-06/txt/msg00269.txt.bz2 This is a multi-part message in MIME format. --------------050801060306050203080102 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 5 ping --------------050801060306050203080102 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Attached Message" Content-length: 9100 Return-Path: Delivered-To: cagney@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 7CA032B9D for ; Wed, 26 May 2004 11:00:44 -0400 (EDT) Envelope-to: cagney@gnu.org Delivery-date: Tue, 25 May 2004 20:46:16 -0400 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-6.2.4) for cagney@localhost (single-drop); Wed, 26 May 2004 11:00:44 -0400 (EDT) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.34) id 1BSmYi-0007mW-Gc for cagney@gnu.org; Tue, 25 May 2004 20:46:16 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BSm8H-0007mg-Rm for cagney@gnu.org; Tue, 25 May 2004 20:19:29 -0400 Received: from [12.107.209.250] (helo=sourceware.org) by monty-python.gnu.org with smtp (Exim 4.34) id 1BSllK-0003ND-MP for cagney@gnu.org; Tue, 25 May 2004 19:55:15 -0400 Received: (qmail 30466 invoked by alias); 25 May 2004 22:55:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com Received: (qmail 30451 invoked from network); 25 May 2004 22:55:11 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 25 May 2004 22:55:11 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i4PMtBi7013565 for ; Tue, 25 May 2004 18:55:11 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i4PMtA007320; Tue, 25 May 2004 18:55:10 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 329A02B9D; Tue, 25 May 2004 18:54:56 -0400 (EDT) Message-ID: <40B3CEC0.2070405@gnu.org> Date: Tue, 25 May 2004 18:54:56 -0400 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Andrew Cagney Cc: Mark Kettenis , drow@false.org, gdb-patches@sources.redhat.com, roland@redhat.com Subject: Re: Revamp sniffer; Was: [obish?sym;rfa:doc] Wire up vsyscall References: <409A8C2A.2010605@gnu.org> <409AA61F.8050807@gnu.org> <20040507012549.GA30182@nevyn.them.org> <409FF3D7.5000106@gnu.org> <200405102140.i4ALe13A001092@elgar.kettenis.dyndns.org> <20040511145344.GA15501@nevyn.them.org> <40A0FFB1.8030407@gnu.org> <20040511172619.GA19487@nevyn.them.org> <40A16FA1.9060506@gnu.org> <200405152057.i4FKvdt2000817@elgar.kettenis.dyndns.org> <40A8F308.9040900@gnu.org> In-Reply-To: <40A8F308.9040900@gnu.org> Content-Type: multipart/mixed; boundary="------------020104090803000506090803" X-Spam-Status: No, hits=-2.0 required=5.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES, USER_AGENT_MOZILLA_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) This is a multi-part message in MIME format. --------------020104090803000506090803 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 175 Mark, Want do you want to do here? Commit daniel's patch for the short term while I clean this up proper over the medium term (appending it to the vsyscall list)? Andrew --------------020104090803000506090803 Content-Type: message/rfc822; name="Attached Message" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="Attached Message" Content-length: 4970 Return-Path: Delivered-To: cagney@localhost.redhat.com Received: from localhost (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D36282B9D for ; Mon, 17 May 2004 14:20:20 -0400 (EDT) Envelope-to: cagney@gnu.org Delivery-date: Mon, 17 May 2004 14:17:10 -0400 Received: from fencepost.gnu.org by localhost with IMAP (fetchmail-6.2.4) for cagney@localhost (single-drop); Mon, 17 May 2004 14:20:20 -0400 (EDT) Received: from monty-python.gnu.org ([199.232.76.173]) by fencepost.gnu.org with esmtp (Exim 4.34) id 1BPmfm-0004hu-D7 for cagney@gnu.org; Mon, 17 May 2004 14:17:10 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BPloO-0008Er-69 for cagney@gnu.org; Mon, 17 May 2004 13:22:31 -0400 Received: from [12.107.209.250] (helo=sourceware.org) by monty-python.gnu.org with smtp (Exim 4.34) id 1BPloG-0008DH-TE for cagney@gnu.org; Mon, 17 May 2004 13:21:59 -0400 Received: (qmail 28396 invoked by alias); 17 May 2004 17:14:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Delivered-To: mailing list gdb-patches@sources.redhat.com Received: (qmail 28389 invoked from network); 17 May 2004 17:14:55 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 17 May 2004 17:14:55 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i4HHEtRo030531 for ; Mon, 17 May 2004 13:14:55 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i4HHEs001094; Mon, 17 May 2004 13:14:54 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id DFDBF2B9D; Mon, 17 May 2004 13:14:48 -0400 (EDT) Message-ID: <40A8F308.9040900@gnu.org> Date: Mon, 17 May 2004 13:14:48 -0400 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: drow@false.org, gdb-patches@sources.redhat.com, roland@redhat.com Subject: Revamp sniffer; Was: [obish?sym;rfa:doc] Wire up vsyscall References: <409A8C2A.2010605@gnu.org> <409AA61F.8050807@gnu.org> <20040507012549.GA30182@nevyn.them.org> <409FF3D7.5000106@gnu.org> <200405102140.i4ALe13A001092@elgar.kettenis.dyndns.org> <20040511145344.GA15501@nevyn.them.org> <40A0FFB1.8030407@gnu.org> <20040511172619.GA19487@nevyn.them.org> <40A16FA1.9060506@gnu.org> <200405152057.i4FKvdt2000817@elgar.kettenis.dyndns.org> In-Reply-To: <200405152057.i4FKvdt2000817@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-2.0 required=5.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,REPLY_WITH_QUOTES, USER_AGENT_MOZILLA_UA version=2.55 X-Spam-Level: X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp) Content-length: 1440 > 2004-01-25 Daniel Jacobowitz > > * i386-tdep.c (i386_gdbarch_init): Check for signal frame first. > * i386-linux-tdep.c (i386_linux_pc_in_sigtramp): Handle > __kernel_sigreturn. > [...] > I'm somewhat reluctant to throw the CFI completely overboard. Yes. > How > about extending the DWARF2 unwinder such that we can set the > [SIGTRAMP_FRAME] attribute based on the function's name? The frame attributes (tramp et.al.) in many cases are orthogonal to the unwind mechanism, but sometimes they are not). At present the frame sniffer is focused solely on identifying and returning an unwinder. The frame's type being identified as an unexpected sid effect. I think this should be inverted vis: frame_sniffer () -> - attributes - unwinder (or NULL, indicating sniff for unwinder) - base (or NULL, indicating sniff for base) - ... so while the type is determined up front, other things are optional. That way here the tramp code would look like: if (name == _kernel_sigreturn) if (cfi at address) return { attribute=TRAMP; unwinder=cfi_unwinder; base=NULL }; else return { attribute=TRAMP; unwinder=alt_unwinder; base=NULL }; this also opens the way for us doing: if (name == solib-trampoline) return { attribute=TRAMP|CALLEE; unwinder=NULL; base=NULL } i.e., it's a trampoline (need to skip it) but let something more generic identify the unwinder. Andrew --------------020104090803000506090803-- --------------050801060306050203080102--