From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32166 invoked by alias); 10 Jun 2004 22:03:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32143 invoked from network); 10 Jun 2004 22:03:30 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 10 Jun 2004 22:03:30 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i5AM3Ri7003580 for ; Thu, 10 Jun 2004 18:03:27 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i5AM3R018526; Thu, 10 Jun 2004 18:03:27 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 5FABF2B9D; Thu, 10 Jun 2004 18:03:24 -0400 (EDT) Message-ID: <40C8DAAC.4070207@gnu.org> Date: Thu, 10 Jun 2004 22:03:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Eliminate register_value_being_returned and legacy_return_value References: <40C8CD62.5080902@gnu.org> <200406102147.i5ALlWUm000576@elgar.kettenis.dyndns.org> In-Reply-To: <200406102147.i5ALlWUm000576@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-06/txt/msg00246.txt.bz2 > Date: Thu, 10 Jun 2004 17:06:42 -0400 > From: Andrew Cagney > > Hello, > > This patch eliminates calls to both register_value_being_returned and > legacy_return_value by inlining / simplifying the callers. Turns out > there was much duplication of effort with both the caller and callees > all performing the same tasks. > > This patch gives me a bad feeling. I had intentionally introduced > legacy_return_value to isolate all the legacy code in a single > function. Yes, that duplicates some of the code, but I think it makes > the code much, much easier to understand. It also makes removing the > legacy code much more easier later on. Did you apply the patch and look at the result? I think what's deprecated is pretty clear. Andrew