From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26302 invoked by alias); 9 Jun 2004 16:20:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26283 invoked from network); 9 Jun 2004 16:19:59 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 9 Jun 2004 16:19:59 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i59GJxi7028649 for ; Wed, 9 Jun 2004 12:19:59 -0400 Received: from localhost.redhat.com (porkchop.devel.redhat.com [172.16.58.2]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i59GJw001650; Wed, 9 Jun 2004 12:19:58 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1180D2B9D; Wed, 9 Jun 2004 12:19:52 -0400 (EDT) Message-ID: <40C738A7.9040900@gnu.org> Date: Wed, 09 Jun 2004 16:20:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: "Nathan J. Williams" Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Some regset-related cleanup for i386bsd-nat.c References: <200405311001.i4VA1Ok1041099@elgar.kettenis.dyndns.org> In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-06/txt/msg00179.txt.bz2 > Mark Kettenis writes: > > >>> * i386bsd-nat.c: Don't include "gregset.h". >>> (supply_gregset, fill_gregset): Make static. >>> (supply_fpregset, fill_fpregset): Remove. > > > I just noticed this in one of my builds. I'm attempting to modernize > and prepare my NetBSD thread support code for integration, and that > code uses the {supply,fill}_{regset,fpregset} functions to implement > the thread-specific fetch_registers and store_registers, based on > register context passed back from the pthread debugging library (It > was quite a boon when I ported it forward from 5.0 to 5.3 and got > these functions to use). If these are removed, is there a good way for > an architecture-neutral bit of code like nbsd-thread.c to go back and > forth between GDB's register storage and native register storage? Have a look at regsets.[hc], the method: set_gdbarch_regset_from_core_section (gdbarch, ppc_linux_regset_from_core_section); they set the general direction for where GDB is going. Andrew