From: Jeff Johnston <jjohnstn@redhat.com>
To: gdb-patches@sources.redhat.com
Cc: msnyder@redhat.com
Subject: [RFA]: Additional dead thread patch
Date: Mon, 07 Jun 2004 21:53:00 -0000 [thread overview]
Message-ID: <40C4E3EB.1020807@redhat.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 725 bytes --]
After updating to current sources today, I have noticed a regression in
print-threads.exp which is due to some missing logic in my June 4th patch. The
problem is a timing issue (it does not occur for my June 4th build). There is a
gdb_assert in thread_from_lwp() which gets triggered because the th_valid flag
has not been set for a zombie thread's thread_info struct.
This patch fills in the zombie thread's thread_info private area since the
information is indeed valid and available.
Ok to commit?
-- Jeff J.
2004-06-07 Jeff Johnston <jjohnstn@redhat.com>
* thread-db.c (thread_get_info_callback): Fill in the thread_info
struct if one exists, even if we are dealing with a zombie thread.
[-- Attachment #2: thread-db.patch --]
[-- Type: text/plain, Size: 1039 bytes --]
Index: thread-db.c
===================================================================
RCS file: /cvs/src/src/gdb/thread-db.c,v
retrieving revision 1.41
diff -u -p -r1.41 thread-db.c
--- thread-db.c 4 Jun 2004 21:28:15 -0000 1.41
+++ thread-db.c 7 Jun 2004 21:35:57 -0000
@@ -275,12 +275,18 @@ thread_get_info_callback (const td_thrha
thread_info = find_thread_pid (thread_ptid);
/* In the case of a zombie thread, don't continue. We don't want to
- attach to it thinking it is a new thread and we don't want to mark
- it as valid. */
+ attach to it thinking it is a new thread. */
if (ti.ti_state == TD_THR_UNKNOWN || ti.ti_state == TD_THR_ZOMBIE)
{
if (infop != NULL)
*(struct thread_info **) infop = thread_info;
+ if (thread_info != NULL)
+ {
+ memcpy (&thread_info->private->th, thp, sizeof (*thp));
+ thread_info->private->th_valid = 1;
+ memcpy (&thread_info->private->ti, &ti, sizeof (ti));
+ thread_info->private->ti_valid = 1;
+ }
return TD_THR_ZOMBIE;
}
next reply other threads:[~2004-06-07 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-07 21:53 Jeff Johnston [this message]
2004-06-07 21:58 ` Daniel Jacobowitz
2004-06-07 22:36 ` Jeff Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40C4E3EB.1020807@redhat.com \
--to=jjohnstn@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox