From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4921 invoked by alias); 7 Jun 2004 18:04:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4770 invoked from network); 7 Jun 2004 18:04:23 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Jun 2004 18:04:23 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i57I4Ki7031339 for ; Mon, 7 Jun 2004 14:04:20 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i57I4J028624; Mon, 7 Jun 2004 14:04:19 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6649D2B9D; Mon, 7 Jun 2004 14:04:15 -0400 (EDT) Message-ID: <40C4AE1F.9060508@gnu.org> Date: Mon, 07 Jun 2004 18:04:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Andrew Cagney Cc: Randolph Chung , gdb-patches@sources.redhat.com Subject: Re: [patch/commit] Fix nested header include in infttrace.h References: <20040526154101.GA7207@tausq.org> <40B4CA7D.7080302@gnu.org> <20040526165722.GB7207@tausq.org> <40B4F027.7060908@gnu.org> In-Reply-To: <40B4F027.7060908@gnu.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-06/txt/msg00131.txt.bz2 > 2004-05-26 Andrew Cagney > > * target.h (PC_REQUIRES_RUN_BEFORE_USE): Delete definition. > * config/pa/tm-hppa.h (DEPRECATED_PC_REQUIRES_RUN_BEFORE_USE): > Rename PC_REQUIRES_RUN_BEFORE_USE. > * breakpoint.c (breakpoint_sals_to_pc): Update. Wrap reference in > #ifdef. I've checked this in. Andrew > Index: breakpoint.c > =================================================================== > RCS file: /cvs/src/src/gdb/breakpoint.c,v > retrieving revision 1.173 > diff -p -u -r1.173 breakpoint.c > --- breakpoint.c 13 May 2004 16:39:10 -0000 1.173 > +++ breakpoint.c 26 May 2004 19:28:09 -0000 > @@ -5025,7 +5025,8 @@ breakpoint_sals_to_pc (struct symtabs_an > > Give the target a chance to bless sals.sals[i].pc before we > try to make a breakpoint for it. */ > - if (PC_REQUIRES_RUN_BEFORE_USE (sals->sals[i].pc)) > +#ifdef DEPRECATED_PC_REQUIRES_RUN_BEFORE_USE > + if (DEPRECATED_PC_REQUIRES_RUN_BEFORE_USE (sals->sals[i].pc)) > { > if (address == NULL) > error ("Cannot break without a running program."); > @@ -5033,6 +5034,7 @@ breakpoint_sals_to_pc (struct symtabs_an > error ("Cannot break on %s without a running program.", > address); > } > +#endif > } > } > > Index: target.h > =================================================================== > RCS file: /cvs/src/src/gdb/target.h,v > retrieving revision 1.59 > diff -p -u -r1.59 target.h > --- target.h 25 May 2004 14:58:31 -0000 1.59 > +++ target.h 26 May 2004 19:28:12 -0000 > @@ -1088,15 +1088,6 @@ extern void (*deprecated_target_new_objf > (*current_target.to_stopped_data_address) () > #endif > > -/* Sometimes gdb may pick up what appears to be a valid target address > - from a minimal symbol, but the value really means, essentially, > - "This is an index into a table which is populated when the inferior > - is run. Therefore, do not attempt to use this as a PC." */ > - > -#if !defined(PC_REQUIRES_RUN_BEFORE_USE) > -#define PC_REQUIRES_RUN_BEFORE_USE(pc) (0) > -#endif > - > /* This will only be defined by a target that supports catching vfork events, > such as HP-UX. > > Index: config/pa/tm-hppa.h > =================================================================== > RCS file: /cvs/src/src/gdb/config/pa/tm-hppa.h,v > retrieving revision 1.73 > diff -p -u -r1.73 tm-hppa.h > --- config/pa/tm-hppa.h 7 May 2004 05:48:50 -0000 1.73 > +++ config/pa/tm-hppa.h 26 May 2004 19:28:12 -0000 > @@ -29,7 +29,7 @@ > #define GDB_MULTI_ARCH 1 > > extern int hppa_pc_requires_run_before_use (CORE_ADDR pc); > -#define PC_REQUIRES_RUN_BEFORE_USE(pc) hppa_pc_requires_run_before_use (pc) > +#define DEPRECATED_PC_REQUIRES_RUN_BEFORE_USE(pc) hppa_pc_requires_run_before_use (pc) > > /* PA specific macro to see if the current instruction is nullified. */ > #ifndef INSTRUCTION_NULLIFIED