From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2234 invoked by alias); 7 Jun 2004 14:06:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2197 invoked from network); 7 Jun 2004 14:05:58 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 Jun 2004 14:05:58 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i57E5qi7024690 for ; Mon, 7 Jun 2004 10:05:52 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i57E5q009288; Mon, 7 Jun 2004 10:05:52 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 663F02B9D; Mon, 7 Jun 2004 10:05:51 -0400 (EDT) Message-ID: <40C4763F.9020104@gnu.org> Date: Mon, 07 Jun 2004 14:06:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Randolph Chung Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfa] Check kernel version for header References: <20040607013534.GA601@tausq.org> In-Reply-To: <20040607013534.GA601@tausq.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-06/txt/msg00119.txt.bz2 > I have a request from the Gentoo maintainers to include this patch. I > don't know if there's any policy/precedence for similar patches that > depends on kernel versions for header files. comments? Short answer: I've no idea. Long answer: I suspect that it is being included to gain access to certain regset offsets used when handling regsets. The `correct fix' is to move the code to hppa-linux-tdep.[hc], make it independant of , and wire it into the regset framework. (I can hear the groans :-). Just remember that the latter will be needed anyway if both 32x64 and remote debugging are to be fully supported. In the mean time `what ever' :-) > randolph > > 2004-06-06 Guy Martin Add a line here reading `Committed by ...'. It makes tracking paperwork easier. You'll see other examples further down. Andrew > * hppa-linux-nat.c: Include the correct version of the header file > depending on the kernel version. > > Index: hppa-linux-nat.c > =================================================================== > RCS file: /cvs/src/src/gdb/hppa-linux-nat.c,v > retrieving revision 1.3 > diff -u -p -r1.3 hppa-linux-nat.c > --- hppa-linux-nat.c 8 May 2004 03:27:24 -0000 1.3 > +++ hppa-linux-nat.c 7 Jun 2004 01:28:11 -0000 > @@ -27,7 +27,13 @@ > #include > #include > #include > +#include > + > +#if LINUX_VERSION_CODE < 0x02052c > +#include > +#else > #include > +#endif > > #include "hppa-tdep.h" > > -- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/