Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <cagney@gnu.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/commit] Fix nested header include in infttrace.h
Date: Wed, 26 May 2004 16:48:00 -0000	[thread overview]
Message-ID: <40B4CA7D.7080302@gnu.org> (raw)
In-Reply-To: <20040526154101.GA7207@tausq.org>

infttrace.h was including target.h, which caused a lot of compile
warnings related to duplicate defines of PC_REQUIRES_RUN_BEFORE_USE.
this fixes it. 

commited as obvious. thx
randolph
2004-05-26  Randolph Chung  <tausq@debian.org>

	* infttrace.h (target_waitkind): Forward declare type instead of pulling
	in header file.
Unfortunatly this is a GCC extension.  It sounds like a header file is 
missing:
	#ifndef FOO_H
	#define FOO_H
	#endif
wrappers?  Adding them is ``obvious''.

Andrew

Index: infttrace.h
===================================================================
RCS file: /cvs/src/src/gdb/infttrace.h,v
retrieving revision 1.3
diff -u -p -r1.3 infttrace.h
--- infttrace.h	6 Apr 2004 18:29:10 -0000	1.3
+++ infttrace.h	26 May 2004 15:34:24 -0000
@@ -22,7 +22,7 @@
 #ifndef INFTTRACE_H
 #define INFTTRACE_H
 
-#include "target.h"		/* For enum target_waitkind.  */
+enum target_waitkind;
 
 extern int parent_attach_all (int, PTRACE_ARG3_TYPE, int);
 extern pid_t hppa_switched_threads (pid_t gdb_pid);
-- Randolph Chung Debian GNU/Linux Developer, hppa/ia64 ports http://www.tausq.org/ 




  reply	other threads:[~2004-05-26 16:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-26 15:41 Randolph Chung
2004-05-26 16:48 ` Andrew Cagney [this message]
2004-05-26 16:57   ` Randolph Chung
2004-05-26 19:29     ` Andrew Cagney
2004-06-07 18:04       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40B4CA7D.7080302@gnu.org \
    --to=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=randolph@tausq.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox