From: Andrew Cagney <cagney@gnu.org>
To: Robert Picco <Robert.Picco@hp.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: new gdb remote packet type
Date: Wed, 12 May 2004 18:20:00 -0000 [thread overview]
Message-ID: <40A26AF4.4050001@gnu.org> (raw)
In-Reply-To: <409A95AB.6020101@hp.com>
Yes, this is the key, use it conditionally, nice.
+ switch (remote_protocol_p.support)
+ {
+ case PACKET_DISABLE:
+ break;
+ case PACKET_ENABLE:
+ if (fetch_register_using_p (regnum))
+ return;
+ else
+ error ("Protocol error: p packet not recognized by stub");
+ case PACKET_SUPPORT_UNKNOWN:
+ if (fetch_register_using_p (regnum))
+ {
+ /* The stub recognized the 'p' packet. Remember this. */
+ remote_protocol_p.support = PACKET_ENABLE;
+ return;
+ }
+ else
+ {
+ /* The stub does not support the 'P' packet. Use 'G'
+ instead, and don't try using 'P' in the future (it
+ will just waste our time). */
+ remote_protocol_p.support = PACKET_DISABLE;
+ break;
+ }
+ }
sprintf (buf, "g");
To get this in, there's some additional leg work:
- copyright assignment?
- documentation (see gdb/doc/gdb.texinfo near the end)
- a corresponding gdbserver patch
- not to forget, ChangeLogs :-)
Andrew
next prev parent reply other threads:[~2004-05-12 18:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 0:45 Robert Picco
2004-04-16 18:33 ` Andrew Cagney
2004-04-22 15:45 ` Robert Picco
2004-04-22 16:09 ` Andrew Cagney
2004-04-29 15:31 ` Robert Picco
2004-04-30 17:31 ` Andrew Cagney
2004-05-04 17:56 ` Robert Picco
2004-05-05 19:10 ` Andrew Cagney
2004-05-06 19:41 ` Robert Picco
2004-05-11 17:31 ` Robert Picco
2004-05-12 18:20 ` Andrew Cagney [this message]
2004-05-12 18:31 ` Daniel Jacobowitz
2004-05-12 18:59 ` Robert Picco
2004-05-12 20:55 ` Daniel Jacobowitz
2004-05-12 22:16 ` Robert Picco
[not found] ` <40A279AF.30603@gnu.org>
2004-05-12 20:53 ` Daniel Jacobowitz
2004-08-02 15:51 ` Robert Picco
2004-09-24 20:07 ` Andrew Cagney
2004-09-25 16:33 ` Eli Zaretskii
2004-09-27 19:21 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A26AF4.4050001@gnu.org \
--to=cagney@gnu.org \
--cc=Robert.Picco@hp.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox