From: Andrew Cagney <cagney@gnu.org>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFC/RFA] Print in-memory struct return values
Date: Tue, 11 May 2004 23:53:00 -0000 [thread overview]
Message-ID: <40A1675A.4010401@gnu.org> (raw)
In-Reply-To: <200405091051.i49Ap6a2027479@elgar.kettenis.dyndns.org>
How come it doesn't work?
Popping the caller's frame should (assuming the unwind info is correct)
restore the struct-return address register to the value that the callee
expects. return_value can then use that register value to find the
location at which to store the struct?
The problem is in the "assuming the unwind info is correct". It's not
there. It will probably never be there. This isn't a normal register
save/restore. The incoming address will be on the stack. The callee
moves it into %eax somewhere, but we don't know where and when. You
simply can't express this in DWARF2 CFI.
You can. %eax would start out as on the stack, and then later be marked
as ``in register''. It's just the reverse flow of what happens to other
registers.
Now, we could do some nifty prologue/epilogue analysis and make a good
guess at where the address is stored. Compilers seem to either do the
move in the prologue (as the SVR4 ABI suggests, see
i386_analyze_struct_return()) or leave the address on the stack until
the epilogue (as GCC does). However, we can never be sure. This
would lead to the unreliabilities you were trying to get rid of when
gdbarch_return_value() was instroduced.
Ah. This is what needs to be added to the return_value documentation.
Andrew
prev parent reply other threads:[~2004-05-11 23:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-07 17:07 Mark Kettenis
2004-05-07 22:35 ` Andrew Cagney
2004-05-07 23:10 ` Mark Kettenis
2004-05-08 19:58 ` Mark Kettenis
2004-05-12 17:47 ` Michael Snyder
2004-05-15 21:26 ` Mark Kettenis
2004-05-15 22:12 ` Andreas Schwab
2004-05-16 10:28 ` Mark Kettenis
[not found] ` <200405081958.i48JwlUU000353@elgar.kettenis.dyndns.org>
[not found] ` <409D4216.4050401@gnu.org>
[not found] ` <200405082101.i48L1NUK000503@elgar.kettenis.dyndns.org>
2004-05-08 21:14 ` Andrew Cagney
2004-05-08 23:02 ` Mark Kettenis
2004-05-09 13:59 ` Andrew Cagney
2004-05-09 14:03 ` Mark Kettenis
2004-05-11 23:53 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A1675A.4010401@gnu.org \
--to=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox