From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56506 invoked by alias); 2 Nov 2017 13:27:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56482 invoked by uid 89); 2 Nov 2017 13:27:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Nov 2017 13:27:12 +0000 Received: from ESESSHC019.ericsson.se (Unknown_Domain [153.88.183.75]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 40.8C.32016.E2D1BF95; Thu, 2 Nov 2017 14:27:10 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.75) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 2 Nov 2017 14:26:52 +0100 Received: from [142.133.48.133] (192.75.88.130) by AM3PR07MB305.eurprd07.prod.outlook.com (2a01:111:e400:881b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.4; Thu, 2 Nov 2017 13:26:51 +0000 Subject: Re: [PATCH 09/10] Make tdesc_type::u::u::fields an std::vector To: Yao Qi CC: , Simon Marchi References: <1509414120-14659-1-git-send-email-simon.marchi@ericsson.com> <1509414120-14659-10-git-send-email-simon.marchi@ericsson.com> <86vaitvw0z.fsf@gmail.com> From: Simon Marchi Message-ID: <409e1beb-1f18-f5d5-9973-b060925c8536@ericsson.com> Date: Thu, 02 Nov 2017 13:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <86vaitvw0z.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BN6PR17CA0011.namprd17.prod.outlook.com (2603:10b6:404:65::21) To AM3PR07MB305.eurprd07.prod.outlook.com (2a01:111:e400:881b::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72a9fdcd-844d-4f6e-e13a-08d521f560d4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603238);SRVR:AM3PR07MB305; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB305;3:Xsn5a/2tTAfuDqgxUGMKRK9dRuDI6MWF0vkgkVbRFhAuZ9rwuI/mqYNaxlOqdXtIYY5pCQZUNPJ6hSex0VS/XgxRTV3oEVw9tkaWMoV/ldFq+8oviXWr4VmoJk9oXV5yr7C74F68Y1+NFhoxSE7P26/RhAnSUdtIUMBkHKVoHoz+ncInd1QgJDtTmAgiUhx2I4tG4rQ8KYcKIvv+h7aYer+D8ZHCDvEYaVjEoxFQuxor3x/CcYjsNNRB46ygoPV1;25:EZ4yUjPsCjJ2z6cfWePPzFSx1aJC5bNClBkut8i4mWCNTf44L9Iqk9zSTeW0oIfwLw3rn/OkB7Gvel6527yaZ6kGfkVEQWoRDftpaMTn6EK89PsQ7PHqyvSMIaFmCHCkqHyISgg/yyw6vmTKg89Wz77+4wQdMKXTzbtw98SEwUfYWtTYLR3zw9YyeoVOEQ7nFO3jGENNh9EC3tQyufZXObx9qplDA5FzqrmCrcKDpXTrnMUlqiJrfeoKblZ2mC1GWeW6yPCW9syyt5HdFI756pwcMvRjU20xG1L1NhJVF/sedK1CW0OsCKcAT6nhAIuB6Aa/1safcYgEF4zoIpRr4A==;31:lbHJIF5M817ygZDnnGEYaww3qPopJmtCu2g+tNyg5C1YCvdrO3NIsG/Ujnq/7p73cVhinkvPujAYC+nz9AlV+djRTD155R1cvij0Sd6jwODbtSwyVu2WWQrnmsf2l+s1EFr/oyXFwpcctPyctPwjOywtM9UmrP675IK+1y/6gIj1B4mVKeUm5iXCeKsHg/48xWvtzgzfH6+S+gKGTcqGSy83vvZ6eTL9giAgO0uyQmw= X-MS-TrafficTypeDiagnostic: AM3PR07MB305: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB305;20:7FYsoKwHPauAgLjv3xZrg6/L3rv7pZQFjQEYyZcWtZQ8GaCNQWxQR/fCWCcZVMEGtXV+HJDJBdfDhtV2hF/p6jklvA0HaEVUfp0bHF11/lh0j3muBysDEwEgdgDxNlwzmJKFFxzmFD0wv1N6x3yN7nZlKWFZ3fYEu3xEkMjdRx8oGjq0pyL8xyb5s4wL/PQORxC4jxZhi1XzuVbP3C2g6xMFOU5b0SirSmW4IVh7mHe9Ur6qbLew1tqfDOrxb7A3PDLXVLTfblbj8+zzAI4Q003Ph63eqlEeQb+jQ8zXU7ML9sntuA/04cTOYkwm3Hufq0hRJ00vg5JnSyQ3P5vtjUUlfG60+GvSFS2Ked8tUd+5JU4k7XZd5aD6qOfcLR2PTCcJi2FB7OIjgIf26NuMvTl5RDU/D+x+QQvSdW+DuQrA9PPJtrCsp+0atjMmVbtcV6sCjCYmwWoW2Y7ksHF8rXCHMRbYRvRih6f9OvCdhwbf2VoNAzlDDB6uZToLbSp4;4:4nix2S+Bir0NK7IlkruLZQaWl8E5OegArrBUM/F2r38nVhEJbLYyvzWQFxs+Dj1UDH8iGJ6pr2V+s1t6ClFAtavsfVIx942+3mmdGtR4r42w5JR56m4BGqKRlw8LK0C0Fy+UPeEDFT6l51sdNRclC+IH1DTlVlTNuvfShQhWNGwQjywjTZncLMGI9Z47xLvGQzZiKsLIYutbGwBjqka+wK1TlkS0aRrWxJhmizKxst7chqFfsMIjL9D7xCM6imDEbAAe6hsLrEhreNOw4MNdsEWk1r+qvyQeLwUuCq07pcTtq7D6ZGWqk28NeiUOoAxj X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(3231020)(3002001)(10201501046)(93006095)(93001095)(6041248)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123560025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM3PR07MB305;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM3PR07MB305; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(346002)(376002)(199003)(377424004)(189002)(24454002)(189998001)(76176999)(229853002)(50986999)(54356999)(6486002)(31686004)(50466002)(53546010)(6246003)(53936002)(33646002)(106356001)(39060400002)(105586002)(3846002)(6116002)(101416001)(4326008)(64126003)(230700001)(6666003)(68736007)(5660300001)(23676003)(58126008)(83506002)(7736002)(36756003)(49976008)(305945005)(6916009)(65806001)(65826007)(65956001)(66066001)(47776003)(478600001)(316002)(1411001)(2950100002)(86362001)(31696002)(2906002)(25786009)(8936002)(16526018)(81156014)(16576012)(8676002)(81166006)(97736004)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR07MB305;H:[142.133.48.133];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA3TUIzMDU7MjM6dGpYd1BnNlBYalpzeW82TXYzZjBxZ1Q3VkZj?= =?utf-8?B?OWFKSTloRXRvRDZ0ZkZOVE8rQ0NTRlUvdW0raWdSSlIvb01QUlRYUloyQnN2?= =?utf-8?B?UGxUdUJ1ZW9qYXRyajVKNXNKQ0FaNjhCRUJsL1htYWhMNHMvdVdyTXJNWnFB?= =?utf-8?B?N3hzNjRNM3hHbjRvSkRjMGV6K3h6VVQxTU95YnFqWHdNKzkrZW0xUXZIRE9x?= =?utf-8?B?Y0hNV2pqUmNUbmxXRTdlSEliMmZja2lnUWduM1F0VFhnNDV0VGhMZ0VqUG56?= =?utf-8?B?b0RwWEl1Z1paZXpJZm9zb0VUVmc5eGhBNlMweGFpUVlBRkFWTVU1MTBJVVd4?= =?utf-8?B?SkgvNUJlL2ZMWVBuZHA0bU8vK0lSNkgrNkUrUzU3V051bzBVZlhhdkdVVytL?= =?utf-8?B?TXVEY0RVQ3lmMnRad1JUTnJ6N3Q0S0MyeFZ0RFpJQXg0OVNWcmJ5MXhmZytN?= =?utf-8?B?ekdVSW5lWkV1M3BNQTQ4d2NmdVRjektRT1JhRTNMdzVkRWNnRUs1REZ4dFpy?= =?utf-8?B?NXJPc1l5ZFIydXBycXZLaElVMDdxem44OTZLd3Q0dEtGRFhXeHpBNld0WnVm?= =?utf-8?B?b3NxQWNnNGo0TUV5eHBVa0lDV21TMzNlNEl1TEpYajhDNGc3ckhxcW1leUda?= =?utf-8?B?WEVvQVlNY3h1clUrbURWS1Q3YUUxZUhLNGJpNUNMejNCbCtuQk14R2JBRkFC?= =?utf-8?B?R2l4WnE3dEY0MHdhRFB1M1o2L2c3OXhrbWRHdkc5R2QxbW8rRzgxVDAyYXpj?= =?utf-8?B?eXdiRDZaZXg2ZFF1UGZoR3FWRGkxRHN3T1pRYTFtSUtZWG5adEppOEhKb2hP?= =?utf-8?B?a0R2UTErN3pTQzlTUHFzdTNBd3RtVTg2eGZZdk82K1BJOXlJcmJJVkVjMW40?= =?utf-8?B?SE9iV2ZhaUlabUJUVmpnQjhOLzlMcDRna2Fnajk0SHgxUTNPUTRqSTB0Tmlv?= =?utf-8?B?M2hNRzZvVlBJQzJlc3NEVTUweklzUUtQNlZaTjRkMmVwemd6OElFUkhsTFR0?= =?utf-8?B?MFRGc1k3bzRiRnVjUi9Eek1UanhvMGlZLy85bExhRWk1Yndpa0dUVlE5V2pC?= =?utf-8?B?Z05mYWkwUm0rNDJMSEovc1RRejdDc3JybjJOQ1BYWXN3QlZkUGR2QlhvZms0?= =?utf-8?B?MzZxazF5cUl3RzZDQTdkQVY4QVlkcC9jZ0IyZnV1eG05Y1pKUXJsQ011bGNY?= =?utf-8?B?OXJrUm5KTE1tdjVTQW12TUlmcWdFUkE1bVcwODNVd1VzZ1huakRFbnUrSnBK?= =?utf-8?B?aVpBeGhMSDZTSmxPSWhOUnBMdDJzMFZNQ2JEbmkwVFFEMzNGSllHdThvWXhB?= =?utf-8?B?MkdydThScnQ3M0NXSDlpZGR2amtMcmJScS92dFBwN0FFVlQyeDlvMHlWVjhi?= =?utf-8?B?ajErdDZXYWV0TlM3dDlKZ2gweHkvY0c2Qk5mVTVwbjlNUVBVTTVaY20rVVQx?= =?utf-8?B?Q2pCMTNDV1daOGlTb2wvSHBhTG9Wa0xodWI0WFZ4N0NOT2JFVzh0OENPYnZw?= =?utf-8?B?S0psaVZNL0lzVnZKU0JGemxBMlMwQU5NYnBKaDBGaFBhSU1vMThBL1FuN21x?= =?utf-8?B?YTQzLzNFdXhZR1RxTHFxeE1tbVRWMHpFbDVuUkl6ZWx2RTBrSDdtWnlkVWo5?= =?utf-8?B?ekdUdCsydWhGZytld1NJR3ZCeC9WdVF1Mm02QU5hdzJzMjB5bmplbkU4L01y?= =?utf-8?B?VzM2RTBtaklMeUhkVUJqQy9sRjBFZk0rZ0VkKzJObW9ML1grRkdOWEJKbVRt?= =?utf-8?B?elAvb0IyOXZvQzBQcGpBZ2JsMjRGNzJPalk0NjVuWSsyTFJzZjlDNStoNzNZ?= =?utf-8?B?Q0Yrcy84T3h4dFhXYkJjc3BnbjNVM05DNUp2TnhOaUt6VnIxKzdqdHRpYzFx?= =?utf-8?Q?kh1kMezpSSY3m8YOI2lIh+VBpuaw4aw?= X-Microsoft-Exchange-Diagnostics: 1;AM3PR07MB305;6:gOaO43K+WDCbgJpi3/xJJSa5NIuXm+K1bSs6DJw6yyLpj37tWW5/lsHVkgdh7XFww146e6wfI6L0QjLKVCyTkZZLIGqNZX0aNRhZIWowju9svju3OPGOzjcuis1ylGccQZXevAJYlAvvSLbYwzaL8wmCAQ8ibFOxTNmYssr+Udr8aFUiiDOHACxSH4A6tN7ew/63nmOvOk0iXjoUdGYC8w/DufAcOPQqTf3uPFRj6H3t4S33gO3K9fwDA8BaO02Br70cz5LY3TPp4Wsoxg2xgXQDgAp/WoxJcKJ1JHAQf9gDsVj1wv0W9Z/TSVZnmZ/JIumowYGRMCqmYA+UCxsekSEUZTsprcK3da1phWvLbks=;5:E7x97s68tOLOx79m3uzK+W/iDBu5wuONvZjqijJ78brwch1/8Z8D9uM0wWqPu8vHfWPWQz5mleV8pXC9B/nevEcGMjcbmSE7lOGbBBXb+MdEMshPK9RvvAYhCGuorfmX0kAXB6RdlyUlpSfJGPKoLpunOH1SFZpZlf+ZgyY8XZo=;24:gpsR36MUI3LJSJ6FUiqIYQS//y2uiQfqfFDGTNUY6M0kxwFpWiE78D983fa7WfnmSHrDgP4iIE1VDuZAonHSTubBfDxoaCvEBtgLOPYOejQ=;7:RjBUEjIOI1BuGxT6xZcjEyg5ps16CWfNqRZPV79F1KqsIA6/xNmD28qCV60UhuQL2EgiJvssEcQ/OlU9Scla+5pnh0WStAme8tJyLdyAm0rWx1SHclr3ZHC8ULbQ8IiVeigcLpVgXQOYyXxjp6D6cHDrbJSs1vsywsDIP7dVIGN4ZYcz1QV5RFq83Y+KNX3OpLuBcLg/I8brUvf5SH+KaZvE+85emzBX2qYuk4SY0W9eR/P0r7UneeueMHERd6QT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 13:26:51.1811 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72a9fdcd-844d-4f6e-e13a-08d521f560d4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR07MB305 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00029.txt.bz2 On 2017-11-02 06:02 AM, Yao Qi wrote: > Simon Marchi writes: > >> This patch makes the tdesc_type::u::u::fields an std::vector of >> tdesc_type_field. The difficulty here is that the vector is part of a >> union. Because of this, I made fields a pointer to a vector, and >> instantiate/destroy the vector if the type is one that uses this member >> of the union > > Hi Simon, > Did you consider remove that union by sub-class tdesc_type. We can add > to new sub-classes, tdesc_type_with_fields and tdesc_type_vector, for > example? I tried, but didn't get to something I thought was nice. It should be the right way to do it with sub-classes though, I'll try a bit harder :) Simon