From: Andrew Cagney <cagney@gnu.org>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/mi testsuite] Handle missing inferior I/O for mi-syn-frame.exp
Date: Mon, 10 May 2004 18:00:00 -0000 [thread overview]
Message-ID: <409FC352.50807@gnu.org> (raw)
In-Reply-To: <20040508191439.GA20933@nevyn.them.org>
Daniel wrote:
>The output patterns for this test include things printed by the inferior
>program. Obviously, for gdbserver, this output comes out in the wrong
>place. This patch allows it to be missing for noinferiorio; I don't think
>this compromises the value of the test. OK?
Andrew wrote:
Given that testing I/O isn't the objective of this test, just removing
the output looks to be a better option.
Daniel wrote:
+dummy_puts (const char *string)
+{
+ ;
+}
Er, just _remove_ the output.
Done like so. OK? Tested, no regressions on i386-pc-linux-gnu, fixes
8 failures using gdbserver to i386-pc-linux-gnu.
>BTW, we have one test that "verifies" (kfail'd) that output is properly
>MI-encapsulated, and this test unintentionally "verifies" that it isn't.
>Should I just remove recognizing the inferior's printouts unconditionally,
>instead?
Can you rephrase this?
Some test verifies that the output from the inferior is MI encapsulated
- I believe it was mi-console.exp, and it's now KFAILed. If we changed
MI to successfully encapsulate this sort of output, that would fix
mi-console.exp but break tests like this one. That's all I meant.
Good, you were agreeing that the output was irrelevant.
Andrew
prev parent reply other threads:[~2004-05-10 18:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-28 18:28 Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-01 18:17 ` Daniel Jacobowitz
2004-04-02 22:02 ` Andrew Cagney
[not found] ` <20040508191439.GA20933@nevyn.them.org>
2004-05-10 18:00 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=409FC352.50807@gnu.org \
--to=cagney@gnu.org \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox