From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19255 invoked by alias); 7 May 2004 22:35:34 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19248 invoked from network); 7 May 2004 22:35:33 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 7 May 2004 22:35:33 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i47MZX0o031456 for ; Fri, 7 May 2004 18:35:33 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i47MZWv15648; Fri, 7 May 2004 18:35:33 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 12EFD2B9D; Fri, 7 May 2004 18:35:29 -0400 (EDT) Message-ID: <409C0F30.4090409@gnu.org> Date: Fri, 07 May 2004 22:35:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Mark Kettenis Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH/RFC/RFA] Print in-memory struct return values References: <200405071707.i47H7kG5071172@elgar.kettenis.dyndns.org> In-Reply-To: <200405071707.i47H7kG5071172@elgar.kettenis.dyndns.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-05/txt/msg00222.txt.bz2 > The current GDB doesn't print the return value when using `finish' for > functions return structures that are not returned in registers. Note > that this is a regression from GDB 6.0 for many systems. Anyway, the > attached patch provides a way to fix this, and adds the necessary > support to the i386 target. > > If there are no comments, I'll check this in in a few days. Eli, is > the doc bit OK? Why not add another member to `enum return_value_convention' so that return_value() can directly differentate between these two cases? Andrew > Index: ChangeLog > from Mark Kettenis > > * gdbarch.sh (gdbarch_return_value_address): New method. > * gdbarch.h, gdbarch.c: Re-generate. > * infcmd.c (print_return_value): Use new > gdbarch_return_value_address method if provided. > * i386-tdep.c (i386_return_value_address): New function. > (i386_gdbarch_init): Set return_value_address. >