From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20352 invoked by alias); 7 May 2004 01:20:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 20325 invoked from network); 7 May 2004 01:20:39 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 7 May 2004 01:20:39 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i471Kc0q022082 for ; Thu, 6 May 2004 21:20:38 -0400 Received: from localhost.redhat.com (to-dhcp51.toronto.redhat.com [172.16.14.151]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i46KXgv11763; Thu, 6 May 2004 16:33:42 -0400 Received: from gnu.org (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4508A2B9D; Thu, 6 May 2004 16:33:41 -0400 (EDT) Message-ID: <409AA124.6050601@gnu.org> Date: Fri, 07 May 2004 01:20:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-GB; rv:1.4.1) Gecko/20040217 MIME-Version: 1.0 To: Stefan Weyergraf Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] implements MI "-file-list-exec-sections" (updated) References: <200404222356.57808.stefan@weyergraf.de> In-Reply-To: <200404222356.57808.stefan@weyergraf.de> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-05/txt/msg00174.txt.bz2 Lets separate out a few simpler parts: ---- Index: doc/gdb.texinfo > =================================================================== > RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v > retrieving revision 1.202 > diff -u -3 -p -r1.202 gdb.texinfo > --- doc/gdb.texinfo 28 Mar 2004 12:22:55 -0000 1.202 > +++ doc/gdb.texinfo 22 Apr 2004 21:44:09 -0000 > @@ -14574,7 +14574,7 @@ Elena Zannoni. > > @item @var{mi-command} @expansion{} > @code{[ @var{token} ] "-" @var{operation} ( " " @var{option} )* > -@code{[} " --" @code{]} ( " " @var{parameter} )* @var{nl}} > +[ " --" ] ( " " @var{parameter} )* @var{nl}} > > @item @var{token} @expansion{} > "any sequence of digits" > @@ -14698,13 +14698,13 @@ depending on the needs---this is still i > @code{@var{console-stream-output} | @var{target-stream-output} | @var{log-stream-output}} > > @item @var{console-stream-output} @expansion{} > -@code{"~" @var{c-string}} > +@code{"~" @var{c-string} @var{nl}} > > @item @var{target-stream-output} @expansion{} > -@code{"@@" @var{c-string}} > +@code{"@@" @var{c-string} @var{nl}} > > @item @var{log-stream-output} @expansion{} > -@code{"&" @var{c-string}} > +@code{"&" @var{c-string} @var{nl}} > > @item @var{nl} @expansion{} > @code{CR | CR-LF} This part all looks correct, can you just post it separatly with a ChangeLog. ---- > -static void core_files_info (struct target_ops *); > +static void core_files_info (struct target_ops *, struct ui_out *); Again, just this part (through out) is all ok, can you please post it. ---- Now the fun bit ... You'll have noticed I sent out an e-mail asking about ``inferior vs target'', lets ignore that question for this output... > +@smallexample > +(@value{GDBP}) > +123-file-list-exec-sections > +~"Symbols from \"/var/home/ouk/projects/ht20/testproject/test-g\".\n" > +123^done,targets=[ List of targets reflecting the target stack, nice. {target-type-long="Local exec file",target-type-short="exec", here ``target-'' is implied, so would just: short-name= long-name= entry-point= be better? > +filename="/var/home/ouk/projects/ht20/testproject/test-g",file-type="elf32-i386", > +target-entrypoint="0x08048380",sections=[ List of sections, again nice. > +{start-address="0x08048134",end-address="0x08048147",section-name=".interp"}, > +{start-address="0x08048148",end-address="0x08048168",section-name=".note.ABI-tag"}, > +{start-address="0x08048168",end-address="0x08048198",section-name=".hash"}, > +{start-address="0x08048198",end-address="0x08048208",section-name=".dynsym"}, > +{start-address="0x08048208",end-address="0x080482af",section-name=".dynstr"}, > +{start-address="0x080482b0",end-address="0x080482be",section-name=".gnu.version"}, > +{start-address="0x080482c0",end-address="0x08048300",section-name=".gnu.version_r"}, > +{start-address="0x08048300",end-address="0x08048308",section-name=".rel.dyn"}, > +{start-address="0x08048308",end-address="0x08048320",section-name=".rel.plt"}, > +{start-address="0x08048320",end-address="0x08048337",section-name=".init"}, > +{start-address="0x08048338",end-address="0x08048378",section-name=".plt"}, > +{start-address="0x08048380",end-address="0x08048570",section-name=".text"}, > +{start-address="0x08048570",end-address="0x0804858b",section-name=".fini"}, > +{start-address="0x0804858c",end-address="0x080485a0",section-name=".rodata"}, > +{start-address="0x080485a0",end-address="0x080485b4",section-name=".eh_frame_hdr"}, > +{start-address="0x080485b4",end-address="0x080485f0",section-name=".eh_frame"}, > +{start-address="0x080495f0",end-address="0x080495fc",section-name=".data"}, > +{start-address="0x080495fc",end-address="0x080496dc",section-name=".dynamic"}, > +{start-address="0x080496dc",end-address="0x080496e4",section-name=".ctors"}, > +{start-address="0x080496e4",end-address="0x080496ec",section-name=".dtors"}, > +{start-address="0x080496ec",end-address="0x080496f0",section-name=".jcr"}, > +{start-address="0x080496f0",end-address="0x0804970c",section-name=".got"}, > +{start-address="0x0804970c",end-address="0x08049710",section-name=".bss"}]}] > +(@value{GDBP}) > +@end smallexample I like it. But lets get the other changes in first. Sorry for the delay. Andrew