Re: new gdb remote packet type

Andrew Cagney
2004-09-24T20:07:02Z

[-- Attachment #1: Type: text/plain, Size: 1390 bytes --]

[draining my backlog]

> Andrew Cagney wrote:
>
>>
>> To get this in, there's some additional leg work:
>>
>> - copyright assignment?
>>
>> - documentation (see gdb/doc/gdb.texinfo near the end)
>>
>> - a corresponding gdbserver patch
>>
>> - not to forget, ChangeLogs :-)
>>
>> Andrew

I cleaned up the ChangeLog and commited the remote.c change (adding a
nod to Fernando Nasser who wrote a part of the original code).

Eli, How's the attached slightly revised doco tweak?

Andrew

> FSF has a copyright assignment on file for me. The other items you mentioned are contained in the patch below with the exception of gdbserver patch. There wasn't any feedback on 'P' packet support not being in gdbserver. So I'm assuming that not adding 'p' packet support is o.k.
>
> thanks,
>
> Bob
>
> diff -ruN gdb-6.1.1-orig/gdb/ChangeLog gdb-6.1.1/gdb/ChangeLog
> --- gdb-6.1.1-orig/gdb/ChangeLog 2004-06-14 18:39:49.000000000 -0400
> +++ gdb-6.1.1/gdb/ChangeLog 2004-08-02 10:33:03.993382712 -0400
> @@ -1,3 +1,9 @@
> +2004-06-28 Robert Picco <Robert.Picco@hp.com>
> + * Add new 'p' packet to gdb/remote.c. The 'p' is for fetching
> + the value of a single register. It complements the 'P' which
> + writes a single register. Should the remote gdbserver support
> + the 'p', then 'g' packets aren't used.
> +
> 2004-06-14 GDB Administrator <gdbadmin@sourceware.org>

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1135 bytes --]

2004-09-24 Andrew Cagney <cagney@gnu.org>
Robert Picco <Robert.Picco@hp.com>

* gdb.texinfo (Packets): Document the "p" packet.

Index: gdb.texinfo
===================================================================
RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v
retrieving revision 1.214
diff -p -u -r1.214 gdb.texinfo
--- gdb.texinfo 20 Sep 2004 22:26:21 -0000 1.214
+++ gdb.texinfo 24 Sep 2004 20:04:27 -0000
@@ -19963,17 +19963,20 @@ Reserved for future use.

@item @code{O} --- reserved

-Reserved for future use.
-
-@item @code{p}@var{n@dots{}} --- read reg @strong{(reserved)}
+@item @code{p}@var{hex number of register} --- read register packet
@cindex @code{p} packet

-@xref{write register packet}.
+@xref{read registers packet}, for a description of how the returned
+register value is encoded.

Reply:
@table @samp
-@item @var{r@dots{}.}
-The hex encoded value of the register in target byte order.
+@item @var{XX@dots{}}
+the register's value
+@item E@var{NN}
+for an error
+@item
+Indicating an unrecognized @var{query}.
@end table

@item @code{P}@var{n@dots{}}@code{=}@var{r@dots{}} --- write register