Re: RFA: let gdbarch define FP0_REGNUM on rs6000

Jim Blandy
2004-05-04T15:20:25Z

Andrew Cagney <cagney@gnu.org> writes:

> > 2004-05-03 Jim Blandy <jimb@redhat.com>
> > * config/rs6000/tm-rs6000.h (FP0_REGNUM): Delete. Let
> > gdbarch.h
> > define this.
> > * rs6000-tdep.c (rs6000_gdbarch_init): Set gdbarch_fp0_regnum.
> > diff -cr src.no-gplast-fplast/gdb/config/rs6000/tm-rs6000.h
> > src/gdb/config/rs6000/tm-rs6000.h
> > *** gdb/config/rs6000/tm-rs6000.h 2004-05-03 17:32:42.000000000 -0500
> > --- gdb/config/rs6000/tm-rs6000.h 2004-05-03 17:39:34.000000000 -0500
> > ***************
> > *** 64,78 ****
> > #define PROCESS_LINENUMBER_HOOK() aix_process_linenos ()
> > extern void aix_process_linenos (void);
> > - /* Register numbers of various important registers.
> > - Note that some of these values are "real" register numbers,
> > - and correspond to the general registers of the machine,
> > - and some are "phony" register numbers which are too large
> > - to be actual register numbers as far as the user is concerned
> > - but do serve to get the desired values when passed to read_register. */
> > -
> > - #define FP0_REGNUM 32 /* Floating point register 0 */
>
> Note that FP0_REGNUM is on the deprecate hit list, it's superseeded by
> things like reggroups and regsets. As with other code, you should
> s/FP0_REGNUM/RS6000_FP0_REGNUM/ where possible.

Okay. In the RS6000 case, it'd probably be more consistent to simply
use tdep->ppc_fp0_regnum, rather than introducing a new macro.